-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcp: Allow access to secret from trusted build cluster #5956
Merged
k8s-ci-robot
merged 1 commit into
kubernetes:main
from
ameukam:publishing-bot-token-allow-access
Oct 11, 2023
Merged
gcp: Allow access to secret from trusted build cluster #5956
k8s-ci-robot
merged 1 commit into
kubernetes:main
from
ameukam:publishing-bot-token-allow-access
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Follow-up of: - kubernetes#5950 Ensure secret is accessible by the service account for KES running prow-build-trusted. Signed-off-by: Arnaud Meukam <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Done. Ensuring prow special cases for: kubernetes-public
Special case: ensuring k8s-infra-ci-robot-github-token accessible by k8s-infra-prow-build-trusted
Special case: ensuring publishing-bot-github-token accessible by k8s-infra-prow-build-trusted
Updated IAM policy for secret [publishing-bot-github-token].
@@ -1,2 +1,4 @@
- member: group:[email protected]
role: roles/secretmanager.admin
+- member: serviceAccount:kubernetes-external-secrets@k8s-infra-prow-build-trusted.iam.gserviceaccount.com
+ role: roles/secretmanager.viewer
Updated IAM policy for secret [publishing-bot-github-token].
@@ -1,4 +1,6 @@
- member: group:[email protected]
role: roles/secretmanager.admin
+- member: serviceAccount:kubernetes-external-secrets@k8s-infra-prow-build-trusted.iam.gserviceaccount.com
+ role: roles/secretmanager.secretAccessor
- member: serviceAccount:kubernetes-external-secrets@k8s-infra-prow-build-trusted.iam.gserviceaccount.com
role: roles/secretmanager.viewer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/bash
Bash scripts, testing them, writing less of them, code in infra/gcp/
area/infra
Infrastructure management, infrastructure design, code in infra/
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
sig/k8s-infra
Categorizes an issue or PR as relevant to SIG K8s Infra.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure secret is accessible by the service account for KES running prow-build-trusted.