Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp: Allow access to secret from trusted build cluster #5956

Merged

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Oct 10, 2023

Ensure secret is accessible by the service account for KES running prow-build-trusted.

- Follow-up of:
  - kubernetes#5950

Ensure secret is accessible by the service account for KES running prow-build-trusted.

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 10, 2023
@ameukam
Copy link
Member Author

ameukam commented Oct 10, 2023

cc @dims @BenTheElder

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Oct 10, 2023
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin October 10, 2023 23:56
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2023
@ameukam
Copy link
Member Author

ameukam commented Oct 10, 2023

Ref: kubernetes/publishing-bot#353

@dims
Copy link
Member

dims commented Oct 11, 2023

/approve
/lgtm
/hold until needed!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member Author

ameukam commented Oct 11, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 714f004 into kubernetes:main Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 11, 2023
@ameukam
Copy link
Member Author

ameukam commented Oct 11, 2023

Done.

Ensuring prow special cases for: kubernetes-public 
  Special case: ensuring k8s-infra-ci-robot-github-token accessible by k8s-infra-prow-build-trusted 
  Special case: ensuring publishing-bot-github-token accessible by k8s-infra-prow-build-trusted 
    Updated IAM policy for secret [publishing-bot-github-token].
    @@ -1,2 +1,4 @@
     - member: group:[email protected]
       role: roles/secretmanager.admin
    +- member: serviceAccount:kubernetes-external-secrets@k8s-infra-prow-build-trusted.iam.gserviceaccount.com
    +  role: roles/secretmanager.viewer
    Updated IAM policy for secret [publishing-bot-github-token].
    @@ -1,4 +1,6 @@
     - member: group:[email protected]
       role: roles/secretmanager.admin
    +- member: serviceAccount:kubernetes-external-secrets@k8s-infra-prow-build-trusted.iam.gserviceaccount.com
    +  role: roles/secretmanager.secretAccessor
     - member: serviceAccount:kubernetes-external-secrets@k8s-infra-prow-build-trusted.iam.gserviceaccount.com
       role: roles/secretmanager.viewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants