-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Feature: adding a Dev Container to Minikube #21686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…nikube in a Github Codespace or in a Dev Container locally - adding devcontainer.json file and a section in the README
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: star3am The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Hi @star3am. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
"enableNonRootDocker": "true", | ||
"moby": "true" | ||
}, | ||
"ghcr.io/devcontainers/features/kubectl-helm-minikube:1": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @star3am for this PR I am curious where is this image coming from and who builds it ? need a comment to know the origins of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good day @medyagh that image is from the Devcontainer organisation on Github
Specifically the image comes from mcr.microsoft.com/devcontainers/base:debian (latest)
https://github.com/devcontainers/images/tree/main/src/base-debian
The below page contains information on how Minikube is installed using the feature.
https://github.com/devcontainers/features/pkgs/container/features%2Fkubectl-helm-minikube

More information can be found here https://github.com/devcontainers/features/tree/main/src/kubectl-helm-minikube
The Dev Containers used to be a project by Microsoft, but has been migrated to https://github.com/devcontainers
Can you clarify whether you also wanted a comment in the devcontainer.json file referencing these URLs or just this comment?
Thank you for taking the time to look at my PR and thank you for a great project!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this org owned by microsoft or github ?
and how often the image gets updated? I would prefer an image that minikube project can control and can update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @medyagh Thank you for your time! As far as I understand, Miscrosoft used to own it and now it's an Org on it's own. See this announcement microsoft/vscode-dev-containers#1762
Seems to be regular releases such as monthly see here: https://github.com/devcontainers/images/releases
If I understand correctly, do you want a Dockerfile with Image source as Docker in Docker such as FROM docker:dind
and then the minikube install to happen in the Dockerfile? Is that whaat you are looking for?
Feature: adding a Dev Container to Minikube, enabling us to launch Minikube in a Github Codespace or in a Dev Container locally
Once the Codespace or Dev Container is launched

We can run inside the VSCode terminal

minikube start
- Let's open a new Terminal tabNow let's run

minikube start
Now we should have minikube up and running and we can run

minikube
andkubectl
commadsWe can even bring up the Minikube Kubernetes Dashboard by running

minikube dashboard --url
And by going to the Ports tab and right click and opening in new browser

And opening the Minikube Kubernetes Dashboard location on our Github Codespace

This is to my knowledge the fastest way to launch Minikube on the internet for Development / Demo purposes