improve ssh runner copying cert files

[medyagh]

• refactor installCertSymlinks to avoid shell command exploitation
• refactor installCertSymlinks to improve safety by replacing shell command with direct command execution
• refactor TestSetupCerts to improve clarity and update expected command outputs
• refactor Copy function in SSHRunner to enhance command safety and clarity
• refactor CopyFrom method in SSHRunner to use shellquote for command safety

Need to investigage if this Error Logs (in a passed test) in caused by this PR https://storage.googleapis.com/minikube-builds/logs/21923/42385/KVM_Linux_containerd.html#pass_TestISOImage%2feBPFSupport

[medyagh]

/ok-to-test

[medyagh]

/retest-this-please

[medyagh]

/retest-this-please

[minikube-pr-bot]

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21923 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 41.8s    │ 40.9s                  │
│ enable ingress │ 15.6s    │ 15.9s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 42.8s 41.4s 41.7s 41.5s 41.6s
Times for minikube (PR 21923) start: 42.2s 40.5s 40.6s 40.9s 40.4s

Times for minikube ingress: 15.8s 15.2s 15.2s 15.8s 15.8s
Times for minikube (PR 21923) ingress: 15.8s 15.8s 16.2s 15.7s 15.7s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21923 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 23.8s    │ 22.5s                  │
│ enable ingress │ 11.4s    │ 12.6s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube ingress: 10.6s 12.6s 10.6s 10.6s 12.6s
Times for minikube (PR 21923) ingress: 12.6s 12.6s 12.6s 12.6s 12.7s

Times for minikube start: 22.0s 25.3s 25.2s 24.5s 21.9s
Times for minikube (PR 21923) start: 22.4s 21.9s 23.8s 21.6s 22.8s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21923 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 19.9s    │ 20.8s                  │
│ enable ingress │ 21.1s    │ 21.3s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 20.0s 19.0s 19.6s 19.4s 21.5s
Times for minikube (PR 21923) start: 21.4s 19.6s 21.9s 18.5s 22.8s

Times for minikube ingress: 21.1s 20.1s 21.1s 21.1s 22.1s
Times for minikube (PR 21923) ingress: 20.1s 21.1s 21.1s 21.1s 23.1s

[minikube-pr-bot]

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
Docker_Linux_containerd (4 failed)	TestStartStop/group/old-k8s-version/serial/DeployApp(gopogh)	0.00% (chart)
Docker_Linux_containerd (4 failed)	TestStartStop/group/no-preload/serial/DeployApp(gopogh)	0.00% (chart)
Docker_Linux_containerd (4 failed)	TestStartStop/group/embed-certs/serial/DeployApp(gopogh)	0.00% (chart)
Docker_Linux_containerd (4 failed)	TestStartStop/group/default-k8s-diff-port/serial/DeployApp(gopogh)	2.00% (chart)
Docker_Linux_containerd_arm64 (4 failed)	TestStartStop/group/old-k8s-version/serial/DeployApp(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed)	TestStartStop/group/no-preload/serial/DeployApp(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed)	TestStartStop/group/embed-certs/serial/DeployApp(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed)	TestStartStop/group/default-k8s-diff-port/serial/DeployApp(gopogh)	0.00% (chart)
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//data(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//var/lib/docker(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//var/lib/cni(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//var/lib/kubelet(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//var/lib/minikube(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//var/lib/toolbox(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//var/lib/boot2docker(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/VersionJSON(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/eBPFSupport(gopogh)	Unknown

Besides the following environments also have failed tests:

• Docker_Linux_crio: 39 failed (gopogh)

• Docker_Linux_crio_arm64: 41 failed (gopogh)

• KVM_Linux_crio: 15 failed (gopogh)

To see the flake rates of all tests by environment, click here.

[prezha]

/lgtm

re:

Need to investigage if this Error Logs (in a passed test) in caused by this PR https://storage.googleapis.com/minikube-builds/logs/21923/42385/KVM_Linux_containerd.html#pass_TestISOImage%2feBPFSupport

i don't think it's related to this pr: the error comes from the client-go/transport/cert_rotation.go and is probably transient (self-resolved via retries); we've seen these "errors" in other PRs as well - eg, https://storage.googleapis.com/minikube-builds/logs/21924/42387/KVM_Linux_containerd.html#pass_TestFunctional%2fserial%2fStartWithProxy

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,prezha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

/retest

[k8s-ci-robot]

@medyagh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
integration-kvm-containerd-linux-x86-64	0ff1edc	link	true	/test integration-kvm-containerd-linux-x86-64
integration-kvm-crio-linux-x86-64	0ff1edc	link	true	/test integration-kvm-crio-linux-x86-64
integration-docker-containerd-linux-x86-64	0ff1edc	link	true	/test integration-docker-containerd-linux-x86-64
integration-docker-crio-linux-x86-64	0ff1edc	link	true	/test integration-docker-crio-linux-x86-64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.