Skip to content

Conversation

@afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Nov 22, 2025

Import github.com/Parallels/docker-machine-parallels/v2

Follow-up to:

There are no tests, since this obsolete driver doesn't work.

My recommendation is to to remove the driver from minikube.

@afbjorklund afbjorklund requested a review from medyagh November 22, 2025 13:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afbjorklund
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from nirs and prezha November 22, 2025 13:34
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 22, 2025
@afbjorklund afbjorklund force-pushed the internal-parallels branch 2 times, most recently from 0cd281f to c507e3b Compare November 22, 2025 13:53
@medyagh

This comment was marked as resolved.

Import github.com/Parallels/docker-machine-parallels/v2
Use the year of the minikube-machine import

Make sure to add the original license under
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 23, 2025
@afbjorklund
Copy link
Collaborator Author

/ok-to-test

There are no tests for Parallels, but needs to test that it didn't break anything else

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 23, 2025
@k8s-ci-robot
Copy link
Contributor

@afbjorklund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-kvm-containerd-linux-x86-64 c47dc45 link true /test integration-kvm-containerd-linux-x86-64
integration-kvm-crio-linux-x86-64 c47dc45 link true /test integration-kvm-crio-linux-x86-64
integration-docker-containerd-linux-x86-64 c47dc45 link true /test integration-docker-containerd-linux-x86-64
integration-docker-crio-linux-x86-64 c47dc45 link true /test integration-docker-crio-linux-x86-64
integration-none-docker-linux-x86-64 c47dc45 link true /test integration-none-docker-linux-x86-64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21968 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 41.5s    │ 43.1s                  │
│ enable ingress │ 18.1s    │ 16.0s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 44.2s 40.5s 41.1s 41.5s 40.4s
Times for minikube (PR 21968) start: 43.4s 42.0s 44.6s 43.8s 41.9s

Times for minikube ingress: 16.3s 23.3s 15.8s 19.3s 15.8s
Times for minikube (PR 21968) ingress: 15.8s 15.8s 16.3s 16.3s 15.7s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21968 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 21.9s    │ 21.9s                  │
│ enable ingress │ 12.0s    │ 11.6s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 22.7s 20.7s 21.9s 21.3s 22.8s
Times for minikube (PR 21968) start: 23.6s 25.7s 19.9s 20.4s 20.1s

Times for minikube ingress: 10.6s 14.6s 10.6s 11.6s 12.6s
Times for minikube (PR 21968) ingress: 12.6s 10.6s 11.6s 10.6s 12.6s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21968 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 21.3s    │ 22.5s                  │
│ enable ingress │ 20.1s    │ 20.3s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube ingress: 20.1s 20.1s 20.1s 20.1s 20.1s
Times for minikube (PR 21968) ingress: 21.1s 20.1s 20.1s 20.1s 20.1s

Times for minikube start: 19.5s 23.6s 19.7s 22.2s 21.6s
Times for minikube (PR 21968) start: 22.5s 22.0s 22.3s 23.3s 22.4s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_containerd_arm64 (4 failed) TestStartStop/group/old-k8s-version/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed) TestStartStop/group/no-preload/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed) TestStartStop/group/embed-certs/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed) TestStartStop/group/default-k8s-diff-port/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Windows (1 failed) TestErrorSpam/setup(gopogh) Unknown
Docker_Linux_containerd (4 failed) TestStartStop/group/old-k8s-version/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd (4 failed) TestStartStop/group/embed-certs/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd (4 failed) TestStartStop/group/no-preload/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd (4 failed) TestStartStop/group/default-k8s-diff-port/serial/DeployApp(gopogh) 2.00% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants