-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Copy the external parallels driver to internal #21968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0cd281f to
c507e3b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Import github.com/Parallels/docker-machine-parallels/v2
Use the year of the minikube-machine import Make sure to add the original license under
c507e3b to
c47dc45
Compare
|
/ok-to-test There are no tests for Parallels, but needs to test that it didn't break anything else |
|
@afbjorklund: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
kvm2 driver with docker runtime Times for minikube start: 44.2s 40.5s 41.1s 41.5s 40.4s Times for minikube ingress: 16.3s 23.3s 15.8s 19.3s 15.8s docker driver with docker runtime Times for minikube start: 22.7s 20.7s 21.9s 21.3s 22.8s Times for minikube ingress: 10.6s 14.6s 10.6s 11.6s 12.6s docker driver with containerd runtime Times for minikube ingress: 20.1s 20.1s 20.1s 20.1s 20.1s Times for minikube start: 19.5s 23.6s 19.7s 22.2s 21.6s |
|
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
Import github.com/Parallels/docker-machine-parallels/v2
Follow-up to:
There are no tests, since this obsolete driver doesn't work.
My recommendation is to to remove the driver from minikube.