-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Fix: get_version.go returns wrong version when multiple entries exist #21971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix: get_version.go returns wrong version when multiple entries exist #21971
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Caesarsage The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
|
@Caesarsage: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
medyagh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Caesarsage can you plz post an example of running the code with getting version of something with multiple
Hello @medyagh Here's the exampl showing the fix working with multiple versions: Test ScenarioUsing the current Before Fix (using
|
Fixes #21970
The get_version.go tool was using FindSubmatch which returns only the
first match. When go.mod contains multiple versions of the same
dependency (e.g., v74 and v79 for go-github), it would always return
the first (older) version.
This caused automated update PRs to show incorrect titles like:
'CI: update go-github from v74.0.0 to v74.0.0'