Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Migrate elmiko/karpenter-provider-cluster-api #5097

Closed
elmiko opened this issue Aug 8, 2024 · 38 comments
Closed

REQUEST: Migrate elmiko/karpenter-provider-cluster-api #5097

elmiko opened this issue Aug 8, 2024 · 38 comments
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@elmiko
Copy link

elmiko commented Aug 8, 2024

New repo, staging repo, or migrate existing

migrate existing elmiko/karpenter-provider-cluster-api

Is it a staging repo?

no

Requested name for new repository

karpenter-provider-cluster-api

Which Organization should it reside

kubernetes-sigs

Who should have admin access?

elmiko, fabriziopandini, sbueringer, vincepri

Who should have write access?

elmiko, mtulio, vrabbi, mtougeron, chrischdi, enxebre, fabriziopandini, killianmuldoon, sbueringer, vincepri

Who should be listed as approvers in OWNERS?

elmiko, mtulio, vrabbi, mtougeron, chrischdi, enxebre, fabriziopandini, killianmuldoon, sbueringer, vincepri

Who should be listed in SECURITY_CONTACTS?

elmiko, fabriziopandini, vincepri

What should the repo description be?

Cluster API Karpenter provider. Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.

What SIG and subproject does this fall under?

sig cluster-lifecycle, sub-project cluster-api

Please provide references to appropriate approval for this new repo

The naming and migration of the repo has been discussed with the SIG Autoscaling community on 2024-01-15, and the Karpenter community on 2024-01-18, and most recently in the Cluster API community on 2024-08-07.

Additional context for request

This topic will also be discussed after a consensus period on 20 August at the next SIG Cluster Lifecycle meeting.

@elmiko elmiko added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Aug 8, 2024
@elmiko
Copy link
Author

elmiko commented Aug 8, 2024

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Aug 8, 2024
@elmiko
Copy link
Author

elmiko commented Aug 8, 2024

happy for comments on this PR, but we don't want to merge this until after the SIG cluster lifecycle meeting on 20 August 2024.

/hold until 2024-08-20

@vincepri
Copy link
Member

vincepri commented Aug 8, 2024

+1

2 similar comments
@chrischdi
Copy link
Member

+1

@neolit123
Copy link
Member

+1

@neolit123
Copy link
Member

neolit123 commented Aug 9, 2024

github team, we discussed that we need consensus from the sig leads before the migration.
waiting on @fabriziopandini and @justinsb

@vincepri
Copy link
Member

Nit: new name could/should be in line with other providers like cluster-api-provider-karpenter

@elmiko
Copy link
Author

elmiko commented Aug 12, 2024

@vincepri since this is a provider for karpenter i was continuing the naming scheme that aws and azure had established: https://github.com/aws/karpenter-provider-aws, https://github.com/azure/karpenter-provider-azure

just to be clear, the repo in question here does not create cluster-api controllers, it makes a karpenter binary.

@fabriziopandini
Copy link
Member

I'm +1 to host the project in this incubation phase.
Considering the topic, It would be great to have some +1 also from SIG autoscaling and karpenter working group folks
Similarly, it would be well accepted to see other folks who participated to the initial design phase to step up as a maintainer (possibily from a mix of companies too)

@elmiko
Copy link
Author

elmiko commented Aug 28, 2024

Considering the topic, It would be great to have some +1 also from SIG autoscaling and karpenter working group folks Similarly, it would be well accepted to see other folks who participated to the initial design phase to step up as a maintainer (possibily from a mix of companies too)

agreed, i think that would be great.

cc @jonathan-innis @ellistarn @gjtempleton @MaciekPytel to cover karpenter and sig autoscaling people

for the other maintainers, perhaps we should have a discussion at a cluster-api office hours? (i can think of a few people who would be good candidates)

@elmiko
Copy link
Author

elmiko commented Sep 3, 2024

just a quick update, i am planning to attend upcoming sig autoscaling and karpenter wg meetings, and also reach out to a few people directly about maintainership. happy to also have a conversation at an upcoming cluster api meeting.

@MaciekPytel
Copy link

+1
@gjtempleton Unless you have some objections from sig-autoscaling side?

Also - I agree with comments above, we should have someone from karpenter side +1 as well.

@elmiko
Copy link
Author

elmiko commented Sep 10, 2024

i've added Marco Braga (@mtulio) as another owner, he is a colleague at Red Hat who has been following and participating in the initial design work around karpenter capi, and he also has some experience operating karpenter for aws.

@elmiko
Copy link
Author

elmiko commented Sep 10, 2024

i've added Scott Rosenberg (@vrabbi) as another owner, he is a peer from TeraSky who has participated in many of the design and implementation discussions, and has been experimenting with the provider.

@elmiko
Copy link
Author

elmiko commented Sep 10, 2024

i've added Mike Tougeron (@mtougeron) as another owner, he is a peer from Adobe who has participated in the early design and implementation discussions, he also has good experience with cluster-api and has been a regular participant in that community.

@vincepri
Copy link
Member

Thank you @elmiko, exciting progress.

@ellistarn
Copy link

+1, cool stuff

@vincepri
Copy link
Member

@neolit123 @elmiko @fabriziopandini It seems we have reached consensus all around, are we okay to proceed with the migration of the repository?

@neolit123
Copy link
Member

i was waiting for @elmiko to give a ping about that.

@elmiko
Copy link
Author

elmiko commented Sep 11, 2024

hey all, thank you, and yes @vincepri i think we have met all the requests here.

@neolit123
Copy link
Member

@cblecker @Priyankasaggu11929 could you please assist us with this request?
sorry for the long conversation on the ticket.

@jonathan-innis
Copy link
Contributor

+1, karpenter-provider-cluster-api sounds good to me. Excited to see more providers in the community!

@fabriziopandini
Copy link
Member

+1
Great work @elmiko

@Priyankasaggu11929
Copy link
Member

/assign

@elmiko – following the kubernetes-repositories.md#rules-for-donated-repositories, there are a few items that needs addressing before we initiate the migration process:


@elmiko – I will send you an invite to an intermediary org to transfer the repo to Kubernetes project, once above item are addressed. Thank you!

@elmiko
Copy link
Author

elmiko commented Sep 12, 2024

thanks @Priyankasaggu11929 !

i've added the code-of-conduct.md file.

i am working with @mtulio to join the kubernetes-sigs.

i believe @daimaxiaxie has signed the CLA since they have merged PRs to the autoscaler, see https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+is%3Aclosed+author%3Adaimaxiaxie+

@gjtempleton
Copy link
Member

Late to the party on this, but +1 from me as well, great to see.

@Priyankasaggu11929
Copy link
Member

i've added the code-of-conduct.md file.

i am working with @mtulio to join the kubernetes-sigs.

i believe @daimaxiaxie has signed the CLA since they have merged PRs to the autoscaler, see https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+is%3Aclosed+author%3Adaimaxiaxie+

Thanks for the confirmation @elmiko.
I've invited you to the intermediary org for repo transfer.

@daimaxiaxie
Copy link

thanks @Priyankasaggu11929 !

i've added the code-of-conduct.md file.

i am working with @mtulio to join the kubernetes-sigs.

i believe @daimaxiaxie has signed the CLA since they have merged PRs to the autoscaler, see https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+is%3Aclosed+author%3Adaimaxiaxie+

Yes, I signed the CLA. thanks!

@mtulio
Copy link

mtulio commented Sep 13, 2024

i've added the code-of-conduct.md file.

i am working with @mtulio to join the kubernetes-sigs.

The membership request has been opened on #5149! Thanks, @elmiko !

@Priyankasaggu11929
Copy link
Member

i've added the code-of-conduct.md file.
i am working with @mtulio to join the kubernetes-sigs.
i believe @daimaxiaxie has signed the CLA since they have merged PRs to the autoscaler, see https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+is%3Aclosed+author%3Adaimaxiaxie+

Thanks for the confirmation @elmiko. I've invited you to the intermediary org for repo transfer.

@elmiko – friendly ping – this request is currently awaiting the transfer of repo to the intermediate organisation. Thanks!

@elmiko
Copy link
Author

elmiko commented Sep 23, 2024

thanks @Priyankasaggu11929 , is there anything needed from me at the moment?

@Priyankasaggu11929
Copy link
Member

thanks @Priyankasaggu11929 , is there anything needed from me at the moment?

yes, so, you need to transfer the https://github.com/elmiko/karpenter-provider-cluster-api repo to the intermediate org (which I cross-checked you're a member now).

Once you've transferred the repo to the intermediate org, I'll then transfer it to the correct kubernetes-sigs org.

@elmiko
Copy link
Author

elmiko commented Sep 24, 2024

@Priyankasaggu11929 i get this error message "You don’t have the permission to create public repositories on kubernetes-purgatory"

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Sep 25, 2024

i get this error message "You don’t have the permission to create public repositories on kubernetes-purgatory"

addressed off this thread on slack.


Repo transfer is done – https://github.com/kubernetes-sigs/karpenter-provider-cluster-api

PR to add GitHub teams for the new repo: #5183

PR to document new repo to k/community - kubernetes/community#8088

Once above PR are merged, repo migration process will be complete.

@Priyankasaggu11929
Copy link
Member

All PRs are merged. Repo migraiton is complete.

/close

@k8s-ci-robot
Copy link
Contributor

@Priyankasaggu11929: Closing this issue.

In response to this:

All PRs are merged. Repo migraiton is complete.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@neolit123
Copy link
Member

thanks @Priyankasaggu11929

@elmiko
Copy link
Author

elmiko commented Nov 5, 2024

++, thank you @Priyankasaggu11929 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Development

No branches or pull requests