sig-cluster-lifecycle: add karpenter-provider-cluster-api repo #8088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/cluster-lifecycle
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Priyankasaggu11929 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
neolit123
reviewed
Sep 25, 2024
sigs.yaml
Outdated
| @@ -1070,6 +1070,7 @@ sigs: | |||
| mailing_list: https://groups.google.com/forum/#!forum/kubernetes-sig-cluster-lifecycle | |||
| owners: | |||
| - https://raw.githubusercontent.com/kubernetes-sigs/cluster-api/main/OWNERS | |||
| - https://raw.githubusercontent.com/kubernetes-sigs/karpenter-provider-cluster-api/refs/heads/main/OWNERS | |||
There was a problem hiding this comment.
this should be under a new subproject called with the same name as the repo name, instead of enumerating the new OWNERS file under an existing subproject cluster-api.
cc @elmiko
There was a problem hiding this comment.
^ please update if possible @Priyankasaggu11929
There was a problem hiding this comment.
@neolit123, updated.
Priyankasaggu11929
force-pushed
the
karpenter-provider-capi
branch
from
213dd89 to
0a8b49d
Compare
Priyankasaggu11929
force-pushed
the
karpenter-provider-capi
branch
from
0a8b49d to
f05ec9e
Compare
neolit123
reviewed
Oct 28, 2024
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: kubernetes/org#5097
/assign @kubernetes/sig-cluster-lifecycle-leads
cc: @kubernetes/owners