Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mskrocki and LionelJouin as admins for multi-network repos. #5389

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

mskrocki
Copy link
Contributor

@mskrocki mskrocki commented Jan 30, 2025

We want kick off project and list work items in github and track our progress for Multi-Network project.

PR also adds @mskrocki to the kubernetes-sigs (existing member of kubernetes org)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Jan 30, 2025
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2025
@mskrocki
Copy link
Contributor Author

FYI @aojea @LionelJouin

@MikeZappa87
Copy link

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2025
@MikeZappa87
Copy link

@mskrocki you aren’t an org member?

@mskrocki
Copy link
Contributor Author

We are with LionelJouin, but not kubernetes-sigs members. let me update this PR with that.

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2025
@shaneutt
Copy link
Member

shaneutt commented Feb 3, 2025

/approve
/cc @aojea

@k8s-ci-robot k8s-ci-robot requested a review from aojea February 3, 2025 12:33
@aojea
Copy link
Member

aojea commented Feb 3, 2025

/lgtm

glad to see this moving

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2025
@bowei
Copy link
Member

bowei commented Feb 3, 2025

/CC @bowei

@k8s-ci-robot k8s-ci-robot requested a review from bowei February 3, 2025 21:43
Copy link
Member

@Priyankasaggu11929 Priyankasaggu11929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Please move the kubernetes-sigs org membership change to a separate commit of its own, reading Add mskrocki to kubernetes-sigs org.

This is a process requirement for the annual org membership audits.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2025
@mskrocki
Copy link
Contributor Author

mskrocki commented Feb 4, 2025

@Priyankasaggu11929 updated, PTAL.

@Priyankasaggu11929
Copy link
Member

/lgtm
/approve

Feel free to unhold if all other reviews are in place, and PR is ready to merge. Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MikeZappa87, mskrocki, Priyankasaggu11929, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2025
@aojea
Copy link
Member

aojea commented Feb 4, 2025

Feel free to unhold if all other reviews are in place, and PR is ready to merge. Thanks!

/hold cancel

👍

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8250adc into kubernetes:main Feb 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants