Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable the tag check during staging #2176

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

puerco
Copy link
Member

@puerco puerco commented Jul 20, 2021

What type of PR is this?

/kind regression

What this PR does / why we need it:

During the 1.22.0-rc.0 release, we encountered an error where the kube-apiserver binary for s390x was reported as not being properly tagged. This commit disables the check temporarily to enable us to download the staged artifacts for verification.

Signed-off-by: Adolfo García Veytia (Puerco) [email protected]

Which issue(s) this PR fixes:

Ref: kubernetes/sig-release#1633

Special notes for your reviewer:

Does this PR introduce a user-facing change?

This PR temporarily disables the tag check. It will be reverted later.
/priority critical-urgent

NONE

During the 1.22.0-rc.0 release, we encountered an error where the
kube-apiserver binary for s390x was reported as not being properly
tagged. This commit disables the check temporarily to enable us to
download the staged artifacts for verification.

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2021
@puerco puerco changed the title Temporarily disable the tag check during staging stage /merge Temporarily disable the tag check during staging stage Jul 20, 2021
@puerco puerco changed the title Temporarily disable the tag check during staging stage Temporarily disable the tag check during staging Jul 20, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2021
@puerco puerco added this to the v1.22 milestone Jul 20, 2021
@mkorbi
Copy link

mkorbi commented Jul 20, 2021

/lgtm
hope I'm allowed to do this :D

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@puerco
Copy link
Member Author

puerco commented Jul 20, 2021

Of course you are, thank you @mkorbi :)

@k8s-ci-robot k8s-ci-robot merged commit e5e310f into kubernetes:master Jul 20, 2021
@puerco puerco deleted the disable-tag-check branch July 21, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants