Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng: Update kpromo to v3.4.0-1 #25891

Merged
merged 2 commits into from
Apr 6, 2022
Merged

releng: Update kpromo to v3.4.0-1 #25891

merged 2 commits into from
Apr 6, 2022

Conversation

justaugustus
Copy link
Member

Image updates for sigs.k8s.io/promo-tools v3.4.0: https://github.com/kubernetes-sigs/promo-tools/releases/tag/v3.4.0 / kubernetes-sigs/promo-tools#523

Signed-off-by: Stephen Augustus [email protected]

/assign @puerco @cpanato @saschagrunert
cc: @kubernetes/release-engineering
ref: kubernetes/k8s.io#3601, https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-cip-push-image-cip/1511498664818774016

NOTE: the prow promotion updates are purposely elided from this PR to give one more opportunity for testing before these changes are live everywhere

@justaugustus
releng: Update kpromo to v3.4.0-1
85ea443 
Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 6, 2022
@k8s-ci-robot k8s-ci-robot requested review from cpanato and Verolop April 6, 2022 19:31
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/config Issues or PRs related to code in /config approved Indicates a PR has been approved by an approver from all required OWNERS files. area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 6, 2022
cpanato
cpanato approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2022
@justaugustus justaugustus mentioned this pull request Apr 6, 2022
Closed
12 tasks
@justaugustus
Copy link
Member Author

/hold
From @ameukam in https://kubernetes.slack.com/archives/CJH2GBF7Y/p1649273677053989?thread_ts=1647969815.614999&cid=CJH2GBF7Y:

Can we use registry.k8s.io/artifact-promoter ? 🥺

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2022
@justaugustus
Copy link
Member Author

Can we use registry.k8s.io/artifact-promoter ? 🥺

Done!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2022
@ameukam
Copy link
Member

ameukam commented Apr 6, 2022

Thank you!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2022
@puerco
Copy link
Member

puerco commented Apr 6, 2022

/lgtm

crane digest registry.k8s.io/artifact-promoter/kpromo:v3.4.0-1
sha256:f7cc84a270d24dafe7bc719c8e8ec1ad8bf80f952d71e5184bab172e631ab795

saschagrunert
saschagrunert approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 354fc78 into kubernetes:master Apr 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 6, 2022
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key artifact-promotion-presubmits.yaml using file config/jobs/kubernetes/sig-k8s-infra/releng/artifact-promotion-presubmits.yaml
  • key releng-trusted.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/releng/releng-trusted.yaml

In response to this:

Image updates for sigs.k8s.io/promo-tools v3.4.0: https://github.com/kubernetes-sigs/promo-tools/releases/tag/v3.4.0 / kubernetes-sigs/promo-tools#523

Signed-off-by: Stephen Augustus [email protected]

/assign @puerco @cpanato @saschagrunert
cc: @kubernetes/release-engineering
ref: kubernetes/k8s.io#3601, https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-cip-push-image-cip/1511498664818774016

NOTE: the prow promotion updates are purposely elided from this PR to give one more opportunity for testing before these changes are live everywhere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert saschagrunert mentioned this pull request Apr 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato cpanato approved these changes

@Verolop Verolop Awaiting requested review from Verolop

Assignees

@saschagrunert saschagrunert

@ameukam ameukam

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @ameukam @puerco @k8s-ci-robot @saschagrunert @cpanato