Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [email protected] to testgrid-alert-email for master-blocking and master-informing jobs #34548

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add [email protected] to testgrid-alert-email for master-blocking and master-informing jobs #34548

wants to merge 2 commits into from
+30 −26

Conversation

Vyom-Yadav
Copy link
Member

Adds [email protected] to all jobs which have testgrid-dashboards: .*sig-release-master-(informing|blocking).*

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 19, 2025
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/aws Issues or PRs related to aws provider area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Mar 19, 2025
@Vyom-Yadav
Copy link
Member Author

I'll update the generate conf for dra.

@SergeyKanzhelev
Copy link
Member

looks good for sig node. Maybe sig testing representative can approve globally.

@BenTheElder
Copy link
Member

looks good for sig node. Maybe sig testing representative can approve globally.

yeah
/assign

is there any context / discussion / sig release approval we can point to?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2025
@Vyom-Yadav Vyom-Yadav force-pushed the add-release-team-to-alert-emails branch from 682521d to 5cd3d50 Compare March 23, 2025 13:49
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2025
@Vyom-Yadav
Copy link
Member Author

is there any context / discussion / sig release approval we can point to?

Yeah, this has been a longstanding item. It has been mentioned in the previous retros:

CC'ing the current RT lead and Release Signal Lead

/cc @npolshakova @wendy-ha18

@wendy-ha18
Copy link
Member

+1.
The reason for this PR is that the Release Signal team noticed we haven't been receiving auto-alert emails for failing tests on several jobs in master-blocking and master-informing boards during the previous release until now (as Vyom mentioned the retro links above). This has required the team to manually monitor TestGrid, making it harder to quickly create issues and alert the relevant people.

After double-checking the TestGrid configuration, we figured out that the testgrid-alert-email of several jobs hasn't included Release Team (of which Release Signal is a part). Therefore, this PR is created to improve the auto alert email for the upcoming release.

@BenTheElder
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, Vyom-Yadav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2025
BenTheElder
BenTheElder reviewed Mar 24, 2025
View reviewed changes
config/jobs/image-pushing/releng/k8s-staging-artifact-promoter.yaml
@@ -4,7 +4,7 @@ postsubmits:
cluster: k8s-infra-prow-build-trusted
annotations:
testgrid-dashboards: sig-release-releng-blocking, sig-release-master-informing, sig-release-image-pushes, sig-k8s-infra-gcb
Copy link
Member

@BenTheElder BenTheElder Mar 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be a follow-up, but I'm not convinced this should be in release-master-informing? it's not testing kubernetes. (vs sig-release-releng-blocking, that makes sense)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same for ~all of image-pushing/)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open a thread in #sig-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder

@andrewsykim andrewsykim

@aravindhp aravindhp

@npolshakova npolshakova

@wendy-ha18 wendy-ha18

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/aws Issues or PRs related to aws provider area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Auth
Status: Needs Triage
SIG Node CI/Test Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Vyom-Yadav @SergeyKanzhelev @BenTheElder @wendy-ha18 @k8s-ci-robot