Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update note on manage-resources-containers.md on using milliCPU form #44003

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix: update note on manage-resources-containers.md on using milliCPU form #44003

merged 1 commit into from
Dec 22, 2023

Conversation

timjaya
Copy link
Contributor

@timjaya timjaya commented Nov 20, 2023

Fixes #38472 .

Improve wording on manage-resource-containers.md > Note on the CPU resource unit allocation > regarding using milliCPU form. Attempted to make it more clear that using milliCPU for fractional requests makes it easier to avoid the pitfall of using invalid quantities.

This is my first PR, so open to any feedback or comments.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 20, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: timjaya / name: Tim K (5063660)
  • ✅ login: tengqm / name: Qiming Teng (5063660)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 20, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @timjaya!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 20, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 20, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5063660
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/655e6a100832db000878f1e2
😎 Deploy Preview https://deploy-preview-44003--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 20, 2023
@timjaya timjaya mentioned this pull request Nov 20, 2023
Closed
@tengqm
Copy link
Contributor

tengqm commented Nov 21, 2023

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 21, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e4fcd20776c2cef5ed01cf50bb6ca4ac1bab68ff

@timjaya timjaya changed the title fix: update note on manage-resources-containers on using milliCPU form fix: update note on manage-resources-containers.md on using milliCPU form Nov 21, 2023
@niranjandarshann
Copy link
Contributor

@timjaya Could you please squash your commits: https://kubernetes.io/docs/contribute/new-content/open-a-pr/#squashing-commits

@timjaya timjaya force-pushed the fix/manage-resource-containers-note branch from 969be08 to bde18d6 Compare November 21, 2023 06:50
@timjaya
Copy link
Contributor Author

timjaya commented Nov 21, 2023

@niranjandarshann done - forgot to squash the in-console commit. Lmk if that looks good.

kundan2707
kundan2707 reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@niranjandarshann
Copy link
Contributor

niranjandarshann commented Nov 21, 2023 •
edited
Loading

@niranjandarshann done - forgot to squash the in-console commit. Lmk if that looks good.

@timjaya Yes It looks Good to me. Please check with the other failing checks also.

@timjaya
Copy link
Contributor Author

timjaya commented Nov 22, 2023

@niranjandarshann I'm not sure why I'm getting these build fails for such a small change. Is this related to the build fails mentioned in
#43736?

@niranjandarshann
Copy link
Contributor

@niranjandarshann I'm not sure why I'm getting these build fails for such a small change. Is this related to the build fails mentioned in #43736?

You can restart netlify checks by force pushing an empty commit or rebasing against main.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 22, 2023
@timjaya
fix: update note on manage-resources-containers on using milliCPU form
5063660 
Update manage-resources-containers.md

Co-authored-by: Qiming Teng <[email protected]>

Empty-Commit
@timjaya timjaya force-pushed the fix/manage-resource-containers-note branch from a7eced2 to 5063660 Compare November 22, 2023 20:52
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 22, 2023
@timjaya
Copy link
Contributor Author

timjaya commented Nov 22, 2023

@niranjandarshann @tengqm the checks work after a restart!

Anything else I need to do? Or do I just wait for an /approve from you guys?

@kbhawkey
Copy link
Contributor

/remove-tide/merge-method-squash

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit f66ac64 into kubernetes:main Dec 22, 2023
6 checks passed
@timjaya timjaya deleted the fix/manage-resource-containers-note branch December 22, 2023 06:04
lbzss pushed a commit to lbzss/website that referenced this pull request Dec 29, 2023
@timjaya @lbzss
fix: update note on manage-resources-containers on using milliCPU form (
37fafe6 
kubernetes#44003)

Update manage-resources-containers.md

Co-authored-by: Qiming Teng <[email protected]>

Empty-Commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kundan2707 kundan2707 kundan2707 left review comments

@tengqm tengqm tengqm left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees

@tengqm tengqm

@kundan2707 kundan2707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement for k8s.io/docs/concepts/configuration/manage-resources-containers/
6 participants
@timjaya @k8s-ci-robot @tengqm @niranjandarshann @kbhawkey @kundan2707