Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documenting validating-webhook and mutating-webhook audit annotation #47449

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

documenting validating-webhook and mutating-webhook audit annotation #47449

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75478c5
documenting validatingand mutating webhook api server latency
Ritikaa96 Aug 12, 2024
7b5607c
adding clarification to validating-webhook
Ritikaa96 Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions content/en/docs/reference/labels-annotations-taints/audit-annotations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,19 @@ violated from the PodSecurity enforcement.
See [Pod Security Standards](/docs/concepts/security/pod-security-standards/)
for more information.

## apiserver.latency.k8s.io/validating-webhook

Example: `apiserver.latency.k8s.io/validating-webhook: "203.698864ms"`

This annotation shows the measure of the latency incurred in validating webhook(s).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This annotation shows the measure of the latency incurred in validating webhook(s).
This annotation shows the measure of the latency incurred in validating webhook(s). Validating webhooks is done parallel, hence the latency is aggregated using max duration taken.

I want to add this as the last line but don't know if this info is important to add here
Please confirm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have this clarification.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add this in the next commit then


## apiserver.latency.k8s.io/mutating-webhook

Example: `apiserver.latency.k8s.io/mutating-webhook: "305.741049ms"`

This annotation shows the measure of latency incurred in mutating webhook(s).
Since mutating webhooks are done sequentially, latency is aggregated using sum of the durations.

## authorization.k8s.io/decision

Example: `authorization.k8s.io/decision: "forbid"`
Expand Down