Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Update manage-resources-containers.md #48125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ayushpatil2122
Copy link
Contributor

@ayushpatil2122 ayushpatil2122 commented Sep 29, 2024

Issue

#48109
https://kubernetes.io/ja/docs/concepts/configuration/manage-resources-containers/

In this page, k8s manifest attributes limits and requests are translated 制限 and 要求
As a result, I think it's difficult to understand this article.
I think it's better without translating k8s manifest attributes limits and requests. How do you think?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign okabe-junya for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/localization General issues or PRs related to localization language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 29, 2024
Copy link

netlify bot commented Sep 29, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1f0f86c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66f96043b22e4c000836a4ab
😎 Deploy Preview https://deploy-preview-48125--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Okabe-Junya
Copy link
Member

thanks @ayushpatil2122 for your contribution!

cc @kubernetes/sig-docs-ja-reviews

こちらの変更についてどう思いますか?ここでの意思決定がサイト全体に影響すると思うので確認したいです。
requests, limitsが翻訳されておりわかりづらいので翻訳しないようにしたいというPRです。

@Okabe-Junya Okabe-Junya changed the title Update manage-resources-containers.md [ja] Update manage-resources-containers.md Oct 8, 2024
@Okabe-Junya Okabe-Junya linked an issue Oct 17, 2024 that may be closed by this pull request
@kakts
Copy link
Member

kakts commented Dec 9, 2024

/lgtm

sorry for my late response.

It's good to use English instead of Japanese words for 'requirements' and 'limits'.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@Okabe-Junya
Copy link
Member

/lgtm cancel

We need:

  1. resolve conflicts
  2. get agreements from other ja reviewers.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@Okabe-Junya
Copy link
Member

@ayushpatil2122

Sorry for delay in response, please resolve conflicts to move forward, thanks!

@nasa9084
Copy link
Member

nasa9084 commented Dec 10, 2024

Containerのresourceについてのフィールド部分はrequests/limitsに直した方がわかりやすい、はそうだと思うので賛成ですが、訳注で「requestsする」「limitsする」になっている部分は多分単純に動詞としてのrequest/limitだと思うので、それらは訳した方が適切だと思います

I agree with we should leave requests and limits field names as it is, however, some of the changes are verbs and they should be translated.

Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

各コンテナには、0.25cpuおよび64MiB(2<sup>26</sup>バイト)のメモリー要求と、0.5cpuおよび128MiBのメモリー制限があります
Podには0.5cpuと128MiBのメモリー要求があり、1cpuと256MiBのメモリ制限があると言えます
各コンテナには、0.25cpuおよび64MiB(2<sup>26</sup>バイト)のメモリーrequestsと、0.5cpuおよび128MiBのメモリーlimitsがあります
Podには0.5cpuと128MiBのメモリーrequestsがあり、1cpuと256MiBのメモリlimitsがあると言えます
Copy link
Member

@nasa9084 nasa9084 Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Podには0.5cpuと128MiBのメモリーrequestsがあり、1cpuと256MiBのメモリlimitsがあると言えます
Podには0.5cpuと128MiBのメモリーrequestsがあり、1cpuと256MiBのメモリーlimitsがあると言えます

not directly related to the subject of this PR, though


コンテナは、長時間にわたってCPU制限を超えることが許可される場合と許可されない場合があります
コンテナは、長時間にわたってCPUlimitsを超えることが許可される場合と許可されない場合があります
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
コンテナは、長時間にわたってCPUlimitsを超えることが許可される場合と許可されない場合があります
コンテナは、長時間にわたってCPU limitsを超えることが許可される場合と許可されない場合があります

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Please do not translate limits and requests
5 participants