-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] Update manage-resources-containers.md #48125
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
thanks @ayushpatil2122 for your contribution! cc @kubernetes/sig-docs-ja-reviews こちらの変更についてどう思いますか?ここでの意思決定がサイト全体に影響すると思うので確認したいです。 |
/lgtm sorry for my late response. It's good to use English instead of Japanese words for 'requirements' and 'limits'. |
/lgtm cancel We need:
|
Sorry for delay in response, please resolve conflicts to move forward, thanks! |
Containerのresourceについてのフィールド部分はrequests/limitsに直した方がわかりやすい、はそうだと思うので賛成ですが、訳注で「requestsする」「limitsする」になっている部分は多分単純に動詞としてのrequest/limitだと思うので、それらは訳した方が適切だと思います I agree with we should leave |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
各コンテナには、0.25cpuおよび64MiB(2<sup>26</sup>バイト)のメモリー要求と、0.5cpuおよび128MiBのメモリー制限があります | ||
Podには0.5cpuと128MiBのメモリー要求があり、1cpuと256MiBのメモリ制限があると言えます。 | ||
各コンテナには、0.25cpuおよび64MiB(2<sup>26</sup>バイト)のメモリーrequestsと、0.5cpuおよび128MiBのメモリーlimitsがあります | ||
Podには0.5cpuと128MiBのメモリーrequestsがあり、1cpuと256MiBのメモリlimitsがあると言えます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Podには0.5cpuと128MiBのメモリーrequestsがあり、1cpuと256MiBのメモリlimitsがあると言えます。 | |
Podには0.5cpuと128MiBのメモリーrequestsがあり、1cpuと256MiBのメモリーlimitsがあると言えます。 |
not directly related to the subject of this PR, though
|
||
コンテナは、長時間にわたってCPU制限を超えることが許可される場合と許可されない場合があります。 | ||
コンテナは、長時間にわたってCPUlimitsを超えることが許可される場合と許可されない場合があります。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コンテナは、長時間にわたってCPUlimitsを超えることが許可される場合と許可されない場合があります。 | |
コンテナは、長時間にわたってCPU limitsを超えることが許可される場合と許可されない場合があります。 |
Issue
#48109
https://kubernetes.io/ja/docs/concepts/configuration/manage-resources-containers/
In this page, k8s manifest attributes limits and requests are translated 制限 and 要求
As a result, I think it's difficult to understand this article.
I think it's better without translating k8s manifest attributes limits and requests. How do you think?