fixed the container runtime documentation #48398
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
language/en
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
| @@ -171,7 +171,7 @@ follow [configuring a cgroup driver](/docs/tasks/administer-cluster/kubeadm/conf | |||
|
|
|||
| ## CRI version support {#cri-versions} | |||
|
|
|||
| Your container runtime must support at least v1alpha2 of the container runtime interface. | |||
| Your container runtime must support at least v1 of the container runtime interface. | |||
There was a problem hiding this comment.
| Your container runtime must support at least v1 of the container runtime interface. | |
| Your container runtime must support v1 of the container runtime interface. |
There was a problem hiding this comment.
Noted! will apply those chnages.
…he reference for CRI proto
|
I have made the suggested changes, PTAL. |
|
Please address this comment as well: #48398 (comment) |
website/content/en/docs/concepts/architecture/cri.md Lines 34 to 35 in 251a596 I am changing the doc here as |
|
This statement is invalid and need to be changed to simply say that no other versions are supported by the kubelet now: website/content/en/docs/concepts/architecture/cri.md Lines 31 to 33 in 251a596 |
k8s-ci-robot
added
size/S
|
Incorporated the suggested changes. |
|
Deployment Preview for the |
| For Kubernetes v{{< skew currentVersion >}}, the kubelet prefers to use CRI `v1`. | ||
| If a container runtime does not support `v1` of the CRI, then the kubelet tries to | ||
| negotiate any older supported version. | ||
| The v{{< skew currentVersion >}} kubelet can also negotiate CRI `v1alpha2`, but | ||
| this version is considered as deprecated. | ||
| If the kubelet cannot negotiate a supported CRI version, the kubelet gives up | ||
| and doesn't register as a node. | ||
| If a container runtime does not support `v1` of the CRI, then the kubelet cannot register as a node. | ||
| The v{{< skew currentVersion >}} kubelet only supports CRI `v1`. The deprecated `v1alpha2` API is no longer supported. If the kubelet cannot connect to a container runtime using CRI `v1`, it will give up and will not register as a node. |
There was a problem hiding this comment.
now these two paragraphs are saying the same thing twice. Also instead of saying "kubelet gives up" please clarify. I think it still registers the node. It just never removes the Not Ready status.
There was a problem hiding this comment.
Hi @SergeyKanzhelev, It would be great if you could suggest a possible change in the documentation. So that i can directly push those changes.
There was a problem hiding this comment.
This is basically the task - review docs and update them. Sorry, I only have time to review changes and give a quick feedback. Maybe after code freeze I can find more time.
There was a problem hiding this comment.
no problem!
I'll do the needful.
|
@thisisharrsh - would you like to update the PR to incorporate pending feedback? |
Fixes : #48257