Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify foreground cascading deletion #48824

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Clarify foreground cascading deletion #48824

wants to merge 2 commits into from

Conversation

guettli
Copy link
Contributor

@guettli guettli commented Nov 24, 2024

@guettli
Update garbage-collection.md
6a377b0 
Be explicit: it's the garbage collection controller
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 24, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 27937b0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6743968fd51bbb00081a5844
😎 Deploy Preview https://deploy-preview-48824--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guettli
Update garbage-collection.md
27937b0 
Next place to be more explicit: garbage controller
@sftim
Copy link
Contributor

sftim commented Nov 25, 2024

/retitle Clarify foreground cascading deletion

@k8s-ci-robot k8s-ci-robot changed the title Update garbage-collection.md Clarify foreground cascading deletion Nov 25, 2024
sftim
sftim reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

I haven't checked that this is technically correct.

@guettli
Copy link
Contributor Author

guettli commented Dec 13, 2024

LGTM for docs

I haven't checked that this is technically correct.

I got the answer from Jordan Liggitt in #sig-docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@caozhuozi caozhuozi caozhuozi left review comments

@Princesso Princesso Awaiting requested review from Princesso

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guettli @k8s-ci-robot @sftim @caozhuozi