-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update endpoint-slices.md #48951
base: main
Are you sure you want to change the base?
Update endpoint-slices.md #48951
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @Alphamic! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -182,8 +182,8 @@ The control plane mirrors Endpoints resources unless: | |||
set to `true`. | |||
* the Endpoints resource has a `control-plane.alpha.kubernetes.io/leader` | |||
annotation. | |||
* the corresponding Service resource does not exist. | |||
* the corresponding Service resource has a non-nil selector. | |||
* the Endpoints resource does not exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make sense. If you have an Endpoints, it will be mirrored. If you don't have an Endpoints, the control plane correctly doesn't make any EndpointSlices.
Description
EndpointSlice mirroring Content errata
Issue
Refer to the code below
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/endpointslicemirroring/endpointslicemirroring_controller.go#L357
Closes: #