Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 'Namespaces Walkthrough' to tutorials section #49125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move 'Namespaces Walkthrough' to tutorials section #49125

wants to merge 1 commit into from
+2 −1

Conversation

dev-johnn
Copy link
Contributor

Description

Moved https://kubernetes.io/docs/tasks/administer-cluster/namespaces-walkthrough/ to be within https://kubernetes.io/docs/tutorials/cluster-management/
Also, edited _static/redirects to add a redirect from the old URL

Issue

Closes: #48437

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2024
dipesh-rawat
dipesh-rawat reviewed Dec 17, 2024
View reviewed changes
static/_redirects
@@ -453,5 +453,6 @@

/docs/concepts/overview/what-is-kubernetes/ /docs/concepts/overview/ 301
/docs/tasks/administer-cluster/verify-signed-images/ /docs/tasks/administer-cluster/verify-signed-artifacts/ 301
/docs/tasks/administer-cluster/namespaces-walkthrough/ /docs/tutorial/cluster-management/ 301
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the URL might need correction.

Suggested change
/docs/tasks/administer-cluster/namespaces-walkthrough/ /docs/tutorial/cluster-management/ 301
/docs/tasks/administer-cluster/namespaces-walkthrough/ /docs/tutorials/cluster-management/ 301

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the URL might need a different correction.

Suggested change
/docs/tasks/administer-cluster/namespaces-walkthrough/ /docs/tutorial/cluster-management/ 301
/docs/tasks/administer-cluster/namespaces-walkthrough/ /docs/tutorials/cluster-management/namespaces-walkthrough/ 301

@netlify Netlify
Copy link

netlify bot commented Dec 17, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5635d49
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6760d3d9981c4a0008362977
😎 Deploy Preview https://deploy-preview-49125--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Dec 17, 2024

@dev-johnn if you fix https://github.com/kubernetes/website/pull/49125/files#r1888215570 I think we could merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@sftim sftim sftim left review comments

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@tengqm tengqm Awaiting requested review from tengqm

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move "Namespaces Walkthrough" to tutorials section
4 participants
@dev-johnn @k8s-ci-robot @sftim @dipesh-rawat