Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark AnyVolumeDataSource as stable #49535

Open
wants to merge 2 commits into
base: dev-1.33
Choose a base branch
from
Open

Mark AnyVolumeDataSource as stable #49535

wants to merge 2 commits into from

Conversation

sunnylovestiramisu
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 23, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 23, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 11b65ee
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/679ba7e539f05e0008daeff0

@sunnylovestiramisu sunnylovestiramisu mentioned this pull request Jan 23, 2025
Open
@netlify Netlify
Copy link

netlify bot commented Jan 23, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 11b65ee
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679ba7e52ca18700084d095b
😎 Deploy Preview https://deploy-preview-49535--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jan 23, 2025
dipesh-rawat
dipesh-rawat reviewed Jan 23, 2025
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates/any-volume-data-source.md Outdated
- stage: stable
defaultValue: true
fromVersion: "1.33"
locked: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, we don't support locked field in the front matter of the feature gate reference files.

Doc reference https://kubernetes.io/docs/contribute/new-content/new-features/#ready-for-review-feature-gates

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not supported YET. But having it there won't hurt anyway.
We'll later need this information to show users that there are gates that are "locked", which means ... it is there, not yet removed, it is GA'ed, but cannot be set to values other than the default.

@Shubham82
Copy link
Contributor

@sunnylovestiramisu, Please change the feature gate file name to AnyVolumeDataSource.md before making the change as the file name is changed in the main branch. Otherwise, it will create a merge conflict error.

@sunnylovestiramisu
Copy link
Contributor Author

@sunnylovestiramisu, Please change the feature gate file name to AnyVolumeDataSource.md before making the change as the file name is changed in the main branch. Otherwise, it will create a merge conflict error.

Done

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 23, 2025
@Shubham82
Copy link
Contributor

@sunnylovestiramisu, Please resolve merge conflicts.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dipesh-rawat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@tengqm tengqm tengqm left review comments

@drewhagen drewhagen Awaiting requested review from drewhagen

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sunnylovestiramisu @dipesh-rawat @Shubham82 @k8s-ci-robot @tengqm