Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ianychoi to sig-docs-ko-owners & sig-docs-ko-reviews #49551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ianychoi
Copy link
Contributor

@ianychoi ianychoi commented Jan 25, 2025

I'd like to re-apply for sig-docs-ko-owners & sig-docs-ko-reviews role.

I had sig-docs-ko-owners & sig-docs-ko-reviews roles by 2023 (I was removed through #43975 ).
After stabilizing some personal status through 2024 (moving job position), I would like to re-apply for the roles to facilitate Korean L10n progress.

Thank you for the discussion @seokho-son , and appreciate so much in advance if you are supportive on this PR.

It aligns with kubernetes/org#5374 PR on kubernetes/org repo.

Note that I've met the requirements for reviewer:

  • Member of Kubernetes for 3+ months
  • Primary reviewer for at least 5 PRs to the codebase
  • Reviewed or merged at least 20 substantial PRs to the codebase

This commit adds ianychoi to sig-docs-ko-owners
and sig-docs-ko-reviews
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2025
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 25, 2025
@k8s-ci-robot k8s-ci-robot requested a review from tengqm January 25, 2025 01:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2025
@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • ianychoi
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 25, 2025
@ianychoi
Copy link
Contributor Author

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • ianychoi

    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

Please refer to kubernetes/org#5374 thank you.

Copy link

netlify bot commented Jan 25, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5a87a2e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67943f96b784cb0008387ba9
😎 Deploy Preview https://deploy-preview-49551--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants