-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home page enable dark mode #49586
base: main
Are you sure you want to change the base?
Home page enable dark mode #49586
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
d59fe98
to
18eeb3e
Compare
/easycla |
18eeb3e
to
9d46d60
Compare
@milinddethe15 how's this looking? |
9d46d60
to
4710274
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the PR looks great!
One thing I noticed in the deploy preview: on the Case Studies page, the grid view now seems to be missing a few logos, like AppDirect , Nordstrom , NetEase , Squarespace, ThredUp , VSCO and Woorank, and some logos aren’t rendering properly.
OK, we ought to fix those missing logos (or drop the Case Studies section). |
4710274
to
f193950
Compare
f193950
to
7253f7b
Compare
Thanks for spotting that @dipesh-rawat |
7253f7b
to
02caf1a
Compare
Overall, looks really cool! I've noticed a tiny bug at the bottom of the Community page. To fix it, I suggest removing
→
|
I'm also puzzled by the dark mode behaviour in Firefox (134.0.1, 64-bit, Mozilla Firefox snap for Ubuntu). While the main page renders correctly, all other pages (docs, blog, etc.) do not make a switch and are rendered as usual (light mode). I don't normally use the dark mode and thought it was something about my setup. However, all other websites (e.g. GitHub and Google) render everything in the dark mode correctly as much as I browse their different pages. Does anyone else experience the same? |
@shurup This PR adds the support of dark theme for homepage. Later on, support will be extended to all other pages. |
@milinddethe15 oh, thanks a lot for this clarification! I guess I was confused when I saw the Case studies bug being fixed above. We can definitely omit my second comment then, but I think it would still be good to avoid the bug on the Community page. But anyway, LGTM already! |
@sftim Overall, the page looks good. However, in the collapsed top navbar menu view, most of the screen turns white and worst in mobile view. |
@milinddethe15 what's you're appetite for moving this forward? I would be delighted to hand this over to another contributor. |
(in my view, this is almost the last chance saloon for this feature - if we don't staff it enough to merge before April 2025, we should close the issues as not planned) |
I think that's unrelated, and also the double background is likely intended. |
428e7d4
to
f852111
Compare
@sftim What is the plan, if any, to extend dark mode to other pages? Upgrading docsy? |
#25061 is our written record of planning - it's quite sparse. There isn't a secret document with more details than this. |
Co-Authored-By: Tamilselvan Thangamony <[email protected]>
Co-authored-by: Tamilselvan Thangamony <[email protected]>
Co-Authored-By: Tamilselvan Thangamony <[email protected]>
Co-authored-by: Tamilselvan Thangamony <[email protected]>
Co-authored-by: Tamilselvan Thangamony <[email protected]>
f852111
to
a0d1375
Compare
PR #45535, redone for 2025. All credit to @tamilselvan1102.
To see the effect, visit https://deploy-preview-49586--kubernetes-io-main-staging.netlify.app/ in a browser set to prefer dark mode.
Per #37444, this only sets the main page to support light/dark mode. Other pages are not in scope yet.