Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for KaTeX formulas #49592

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for KaTeX formulas #49592

wants to merge 1 commit into from
+30 −0

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Jan 29, 2025 •
edited
Loading

Per https://www.docsy.dev/docs/adding-content/diagrams-and-formulae/#latex-support-with-katex we can have formulae using $\text{K\kern-.23em{\small a}TeX}$. Make it so, and document this in the style guide.

Preview

/area web-development

@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 29, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 29, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2108c45
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679a54431144d70008e45561
😎 Deploy Preview https://deploy-preview-49592--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Okabe-Junya
Okabe-Junya reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, LGTM!

nit, imho: How about including a simple example of a math block to check the rendering?

dipesh-rawat
dipesh-rawat reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice addition!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fbe77f34758b1baf40b66e53200f819fc9e41d12

@sftim
Copy link
Contributor Author

sftim commented Jan 30, 2025

/retitle Add support for KaTeX formulas

@k8s-ci-robot k8s-ci-robot changed the title Add support for KaTeX formule Add support for KaTeX formulas Jan 30, 2025
@sftim
Copy link
Contributor Author

sftim commented Jan 30, 2025

Excellent work, LGTM!

nit, imho: How about including a simple example of a math block to check the rendering?

We could add that to our sample page. For the style guide pages, we don't include rendering checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okabe-Junya Okabe-Junya Okabe-Junya left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@dipesh-rawat dipesh-rawat

Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sftim @k8s-ci-robot @dipesh-rawat @Okabe-Junya