Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the styles for case studies' pages #49598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shurup
Copy link
Member

@shurup shurup commented Jan 30, 2025

Description

This PR iterates on yesterday's #49587 to improve CSS styles for case studies. Mainly, it fixes two issues:

  1. Makes the featured case study (with video) two-columned: a quote on the left and a video on the right (the size of the YouTube embed now allows us to watch it). That's what we will see:

image

  1. Helps to avoid this situation with two narrow text descriptions on smaller screens like it's shown below:

image

It also includes a tiny fix for a single case study page (font colour and extra space for the title).

P.S. It still leaves room for improvement for the mobile view since @Arhell wanted to handle that.

Signed-off-by: Dmitry Shurupov <[email protected]>
@shurup shurup added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Jan 30, 2025
@shurup shurup requested a review from sftim January 30, 2025 06:50
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 30, 2025
Copy link

netlify bot commented Jan 30, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9b372e7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679b214bb1f20e0008bf5d19
😎 Deploy Preview https://deploy-preview-49598--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +77 to +79
display: flex;
flex-wrap: wrap;
align-items: center;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this break any other pages? eg training

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I could check, it doesn't affect any other pages (I found the gridPage class used on the Main and Partners pages).

@sftim
Copy link
Contributor

sftim commented Jan 30, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d7cdfbbdd783679dd274e206aadb9588902381da

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants