Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add an example of a Service-scoped Pod DNS record #49601

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidxia
Copy link
Contributor

This example will help the reader understand. It's also more consistent to provide an example like the preceding Pod-scoped DNS record paragraphs.

follow up to #49532

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jan 30, 2025
@k8s-ci-robot k8s-ci-robot requested review from bowei and thockin January 30, 2025 20:13
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rayandas for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This example will help the reader understand. It's also more consistent to
provide an example like the preceding Pod-scoped DNS record paragraphs.

Signed-off-by: David Xia <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2025
@davidxia
Copy link
Contributor Author

cc @sftim who reviewed #49532

Copy link

netlify bot commented Jan 30, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c182730
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679bdd634d9e330008d1224b
😎 Deploy Preview https://deploy-preview-49601--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 30, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 55e8ab6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679bddca9927b8000773d8e3
😎 Deploy Preview https://deploy-preview-49601--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Jan 31, 2025

cc @sftim who reviewed #49532

/uncc

I'm afraid I'm going to decline to review this one. Once it has LGTM, please assign to the nominated approver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants