Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-1.33] KEP-3619: Promote Fine-grained SupplementalGroups control to Beta #49880

Draft
wants to merge 2 commits into
base: dev-1.33
Choose a base branch
from
Draft

[dev-1.33] KEP-3619: Promote Fine-grained SupplementalGroups control to Beta #49880

wants to merge 2 commits into from

Conversation

everpeace
Copy link
Contributor

Description

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. language/en Issues or PRs related to English language labels Feb 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 24, 2025
@everpeace everpeace mentioned this pull request Feb 24, 2025
Open
28 tasks
@everpeace everpeace changed the base branch from main to dev-1.33 February 24, 2025 10:08
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 24, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 54bb2c0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67bcabf83eba71000748219c
😎 Deploy Preview https://deploy-preview-49880--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2025
dipesh-rawat
dipesh-rawat reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@everpeace Some early feedback. The PR is currently lacking the change to transition the feature gate SupplementalGroupsPolicy from Alpha to Beta. The necessary change should be made in the feature gate description file -
SupplementalGroupsPolicy.md (here).

Please refer to the documentation here for further information.

@dipesh-rawat
Copy link
Member

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dipesh-rawat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify Netlify
Copy link

netlify bot commented Feb 24, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 54bb2c0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67bcabf8ecd51f000982a3a8

@everpeace
Copy link
Contributor Author

The PR is currently lacking the change to transition the feature gate SupplementalGroupsPolicy from Alpha to Beta. The necessary change should be made in the feature gate description file -
SupplementalGroupsPolicy.md (here).

Thanks for the guidance! fixed in 54bb2c0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@drewhagen drewhagen Awaiting requested review from drewhagen

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@everpeace @dipesh-rawat @k8s-ci-robot