Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Update stale information about minikube #49889

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yuto-kimura-g
Copy link
Contributor

Description

  • Remove outdated information
  • Fix dead link

Issue

Closes: #48905

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inductor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/localization General issues or PRs related to localization labels Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2025
Copy link

netlify bot commented Feb 25, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 553bb3a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67bd2808f3eeea0008ab6f86
😎 Deploy Preview https://deploy-preview-49889--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
すみません、Issueのタイミングで気づければよかったのですが、このページってenにはすでに存在しないんですね。

このPRの変更自体はLGTMなのでマージしても良さそうですが、https://k8s.io/docs/setup/learning-environment/ の追従を別途やっても良さそうですね

@Okabe-Junya
Copy link
Member

https://github.com/kubernetes/website/blob/main/content/en/docs/setup/learning-environment/_index.md?plain=1 を見ると、リダイレクトされていて同階層のファイルはなさそうなので、この辺りのクリーンアップをやることになりそうですね

@yuto-kimura-g
Copy link
Contributor Author

@Okabe-Junya

レビューありがとうございます。
こちらこそ、確認不足でした。すみません。
#41725 を見ると、minikube.mdもkind.mdも消そうという話があったようですね。(しかし消えていない?)
このPRはマージせず、minikube.mdを消し、en と同様に/static/_redirects を設定するPRを再度作成したほうが良いでしょうか?
ご教示ください。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] minikube: multi-node clusters are now supported
3 participants