Skip to content

Fix missing closing tag at the Training page #51035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dkarczmarski
Copy link
Contributor

add the missing closing tag to fix the html syntax error

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 24, 2025
@k8s-ci-robot k8s-ci-robot requested a review from drewhagen May 24, 2025 05:34
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2025
Copy link

netlify bot commented May 24, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3e64635
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6835401d8fa9c20008734d2b
😎 Deploy Preview https://deploy-preview-51035--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@jayeshmahajan jayeshmahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it

@jayeshmahajan
Copy link
Contributor

@shurup
Copy link
Member

shurup commented May 27, 2025

/retitle Fix missing closing tag at the Training page
/area web-development

@k8s-ci-robot k8s-ci-robot changed the title fix missing closing tag Fix missing closing tag at the Training page May 27, 2025
@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2025
@dkarczmarski dkarczmarski force-pushed the fix-html-traning-_index.html branch from ca1915b to 3474100 Compare May 27, 2025 04:31
@dkarczmarski dkarczmarski force-pushed the fix-html-traning-_index.html branch from 3474100 to 3e64635 Compare May 27, 2025 04:31
@shurup
Copy link
Member

shurup commented May 27, 2025

Thanks for addressing my suggestion; it looks perfect now!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0e1b454520f7ca3cfbfc4ed3f8bcb1e6e6a9eb4a

@dkarczmarski
Copy link
Contributor Author

/retitle Fix missing closing tag at the Training page /area web-development
@shurup
I also updated the commit message to have the same title as yours above.

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209, jayeshmahajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 10b4d1e into kubernetes:main May 27, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants