Skip to content

add LimitRange section, make small improvements to the VPA write-up #53395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 4 commits into from
Nov 29, 2025
Merged

add LimitRange section, make small improvements to the VPA write-up #53395

k8s-ci-robot merged 4 commits into from
Nov 29, 2025

Conversation

@iamzili
Copy link
Contributor

@iamzili iamzili commented Nov 23, 2025

Description

I propose small improvements to the new VPA write-up and suggest adding a section about LimitRange resources.

Issue

This issue relates to the one created in the autoscaler git repository, but it does not necessarily close it: kubernetes/autoscaler#8839

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 23, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 23, 2025

Welcome @iamzili!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 23, 2025
@iamzili iamzili mentioned this pull request Nov 23, 2025
Open
@netlify
Copy link

netlify bot commented Nov 23, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6cba428
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/692416f356b27d0008770050
😎 Deploy Preview https://deploy-preview-53395--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Member

lmktfy commented Nov 23, 2025

/sig autoscaling

@k8s-ci-robot k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Nov 23, 2025
omerap12
omerap12 reviewed Nov 24, 2025
View reviewed changes
Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a few comments

content/en/docs/concepts/workloads/autoscaling/vertical-pod-autoscale.md
The Recommender analyzes both current and historical resource usage data (CPU and memory) for each Pod targeted by the VerticalPodAutoscaler. It examines:
- Historical consumption patterns over time to identify trends
- Peak usage and variance to ensure sufficient headroom
- Current resource requests compared to actual usage
Copy link
Member

@omerap12 omerap12 Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

content/en/docs/concepts/workloads/autoscaling/vertical-pod-autoscale.md Outdated
In the _Off_ update mode, the VPA recommender still analyzes resource usage and generates
recommendations, but these recommendations are not automatically applied to Pods.
The recommendations are only stored in the VPA object's `.status` field.
The recommendations are only stored in the VPA object's `.status` field. In this mode, only the recommender is active.
Copy link
Member

@omerap12 omerap12 Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d prefer not to change this. All components are active - they just aren’t performing any actions.

Copy link
Contributor Author

@iamzili iamzili Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right all the VPA components are active, I removed those lines in fd7fd62

@omerap12
Copy link
Member

omerap12 commented Nov 24, 2025

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 24, 2025

LGTM label has been added.

Git tree hash: 12bc0650fc2755f80a01e05d51123c7e5d9178ad

@omerap12
Copy link
Member

omerap12 commented Nov 26, 2025

/cc @lmktfy

@k8s-ci-robot k8s-ci-robot requested a review from lmktfy November 26, 2025 20:38
dipesh-rawat
dipesh-rawat reviewed Nov 29, 2025
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit 99a4206 into kubernetes:main Nov 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianmoisey adrianmoisey Awaiting requested review from adrianmoisey

@lmktfy lmktfy Awaiting requested review from lmktfy

3 more reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@aman4433 aman4433 aman4433 left review comments

@omerap12 omerap12 omerap12 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@omerap12 omerap12

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iamzili @k8s-ci-robot @lmktfy @omerap12 @dipesh-rawat @aman4433