fix : redeployment failure when internal ip is modified #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrent working directory, otherwise when the host's internal ip is changed, the redeployment of the etcd certificate will still use the certificate generated by the previous ip, which will result in the failure of the normal connection of etcd
ks-ci-bot
added
kind/bug
RonaldFletcher
changed the title
|
/assign @24sama |
|
@xrwang8 Thnaks for this contributions ! |
|
LGTM label has been added. Git tree hash: 5696d87808181384df4c041ab07def848f34cac4
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pixiake, xrwang8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
|
@all-contributors please add @xrwang8 for code |
|
I've put up a pull request to add @xrwang8! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When deleting the cluster, delete the generated etcd certificates at the same time, to prevent the host from changing the internal ip, resulting in the redeployment failure.
Special notes for reviewers:
None