[scanner] refactor: split oversized RSSFeed source component - #22824
Conversation
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kubestellar-prow
Bot
added
the
size/XXL
|
👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!
This is an automated message. |
✅ Test Coverage CheckAll new source files in this PR have corresponding test files. Checked |
github-actions
Bot
added
the
needs-tests
Auto Test GeneratorThe following new files have no corresponding test file:
Please add tests or apply the |
github-actions
Bot
added
ai-generated
♿ Accessibility Audit (WCAG 2.1 AA)✅ No WCAG 2.1 AA violations detected in audited routes. Powered by axe-core. Target: WCAG 2.1 AA compliance. |
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate Raw failure evidence (from check-run annotations): Remove the |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate Raw failure evidence (from check-run annotations): Remove the |
kubestellar-prow
Bot
added
the
needs-rebase
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
4b14488 to
02af2fb
Compare
kubestellar-prow
Bot
removed
the
needs-rebase
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: All Cards TTFI (Hard Gate), App Visual Regression, Build Frontend, build (linux/amd64, ubuntu-24.04, amd64), build (linux/arm64, ubuntu-24.04-arm, arm64), build-gate, fullstack-smoke Raw failure evidence (from check-run annotations): Remove the |
02af2fb to
e84223b
Compare
github-actions
Bot
removed
the
needs-tests
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate Raw failure evidence (from check-run annotations): Remove the |
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate Raw failure evidence (from check-run annotations): Remove the |
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate Raw failure evidence (from check-run annotations): Remove the |
kubestellar-prow
Bot
added
the
needs-rebase
Extract feed state management from the 856-line RSSFeed.tsx into a useRSSFeed hook (RSSFeed.tsx now 395 lines) and add unit tests for the hook. Rebased onto main: dropped the AlertsContext, ModalRuntime, and DynamicCard portions of the original branch since main already contains equivalent splits (DynamicCard split continues in #22826). Removed an unused eslint-disable directive flagged by the lint ratchet. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
4fbea3e to
c93895a
Compare
kubestellar-prow
Bot
removed
the
needs-rebase
|
Rebased onto main. This PR is now scoped to its titled purpose only: the RSSFeed.tsx source split (856 -> 395 lines plus a 646-line useRSSFeed hook and new hook unit tests). The AlertsContext, ModalRuntime, and DynamicCard portions were dropped because main already contains equivalent splits (the DynamicCard split continues in #22826). Also removed the unused eslint-disable directive that the lint ratchet flagged on the previous run. |
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
✅ Post-Merge Verification: passedCommit: |
1 participant
Fixes #22775
— hive: agent=scanner backend=copilot model=auto