✨ feat: tui client estimated token cost (T28) - #5453
Merged
clubanderson merged 1 commit intoSep 1, 2026
Conversation
Signed-off-by: Danathar <doug.baggett@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The TUI token client can read token counts from
GET /api/tokens, but it has no client method for the dashboard's separateGET /api/costestimate. That leaves the Tokens pane without a source for its documentedCOSTcolumn: every per-agent and fleet cost remains unknown even when the dashboard has calculated an estimate.The cost wire format also uses the numeric value
0for both a genuine$0.00estimate and an unpriced placeholder. Consumers therefore cannot infer whether a value is known from the number alone.Implementation
Client.Costs(ctx)and a narrow response envelope that decodes only theestimatedportion of/api/costthrough the shared authenticatedgetJSONpath.CostSummaryfortotal_usd,by_agent, andunpriced_models, plusCostAgentEntryfor the complete per-agent token and USD breakdown.sourcevalue and exposeCostAgentEntry.Known()so callers use the source tag rather than guessing from USD.CostSummary.AllPriced()so a summary containing models without exact server-side prices cannot be presented as an authoritative fleet total.The client does not calculate prices locally; the dashboard remains the sole pricing authority.
Known()accepts onlysource: "estimated", so an unknown or future source is handled conservatively.Regression coverage
cost_test.goverifies:GET /api/costrequest and full fixture decode, including every requested per-agent field and all unpriced-model names;$0.00value withsource: "estimated"is known, while$0.00withsource: "unpriced"is unknown;AllPriced() == false;*APIErrorbehavior, including method, path, status, and response body.Verification
From
src/:The commands used task-local
GOCACHE,GOTMPDIR, andCCACHE_DIRpaths because this execution environment mounts their defaults read-only; no source or test behavior was altered.Scope
This PR intentionally does not modify the Tokens pane, application refresh loop, native gateway balances, histories, session rows, repository counts, disclaimer, or price calculations. Rendering and joining cost rows to token rows remain T30 work.
Closes #5415
— hive: backend=codex