Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor download virtctl tool if needed #2263

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

rabin-io
Copy link
Collaborator

📝 Description

This should avoid the error we see in the logs, where the task abort if type virtctl exit code is not 0.

image

Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

Hi @rabin-io. Thanks for your PR.

I'm waiting for a kubevirt-ui member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metalice
Copy link
Member

/ok-to-test

@rabin-io
Copy link
Collaborator Author

/retest

@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 13, 2024
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, rabin-io

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 107afcf into kubevirt-ui:main Nov 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants