Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Bump ProtocolVersion to V2, bump Cargo.toml version #50

Closed
wants to merge 2 commits into from

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Jul 6, 2022

Description

Bump ProtocolVersion to V2. This will be reported by policies when consuming the sdk, and expected
by policy-evaluator, which allows us to correctly error when instantiating policies in an old policy-server.

Relates to kubewarden/policy-evaluator#152
Relates to #40
Relates to #41

Test

Deferring testing until I have policy-evaluator/server/and a policy.

Additional Information

Needs a 0.6.3 tag in main once it lands.

Tradeoff

Potential improvement

viccuad added 2 commits July 6, 2022 12:27
This will be reported by policies when consuming the sdk, and expected
by policy-evaluator.
@viccuad viccuad requested a review from a team as a code owner July 6, 2022 10:32
@viccuad viccuad self-assigned this Jul 6, 2022
@viccuad
Copy link
Member Author

viccuad commented Jul 6, 2022

Closing, no need to use ProtocolVersion, we can support v2/verify and check on execution for now.

@viccuad viccuad closed this Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant