-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github actions and subject prefix verification to sdk #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Víctor Cuadrado Juan <[email protected]> Co-authored-by: raulcabello <[email protected]>
Co-authored-by: raulcabello <[email protected]> Co-authored-by: Víctor Cuadrado Juan <[email protected]>
Use SigstoreVerificationInputV2{} instead of CallbackRequestType{} for validation calls. Co-authored-by: raulcabello <[email protected]> Co-authored-by: Víctor Cuadrado Juan <[email protected]>
Co-authored-by: raulcabello <[email protected]> Co-authored-by: Víctor Cuadrado Juan <[email protected]>
Co-authored-by: raulcabello <[email protected]> Co-authored-by: Víctor Cuadrado Juan <[email protected]>
This was
linked to
issues
Jul 12, 2022
flavio
approved these changes
Jul 12, 2022
jvanz
approved these changes
Jul 12, 2022
viccuad
force-pushed
the
wip
branch
2 times, most recently
from
July 13, 2022 08:47
4ae83b1
to
dbc77b2
Compare
flavio
reviewed
Jul 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not merge yet, I want to have the question about KeylessGithubActionsInfo
answered before
Will tag the 0.6.3 on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GitHub actions and subject prefix sigstore verification to sdk, so we can use them in the policies.
Pass SigstoreVerificationInputV1 and SigstoreVerificationInputV2 to wapc instead of using CallBackRequestType directly
Relates #40
Relates #41