Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LinkRule linker #109

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: add LinkRule linker #109

wants to merge 14 commits into from

Conversation

SOF3
Copy link
Member

@SOF3 SOF3 commented Jul 3, 2023

Description

Add a new linker based on a new CRD that defines how to infer parent from the child

Related issues

Contains commits from #211

Special notes for your reviewer:

@SOF3 SOF3 requested a review from xuqingyun July 3, 2023 08:08
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Attention: 961 lines in your changes are missing coverage. Please review.

Comparison is base (55e101a) 17.63% compared to head (4bbb418) 16.22%.
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/aggregator/linker/rule/linker.go 1.02% 193 Missing ⚠️
pkg/crds/apis/v1alpha1/util/util.go 0.00% 133 Missing ⚠️
pkg/crds/apis/v1alpha1/zz_generated.deepcopy.go 0.00% 106 Missing ⚠️
.../crds/client/informers/externalversions/factory.go 0.00% 96 Missing ⚠️
...lientset/versioned/typed/apis/v1alpha1/linkrule.go 0.00% 86 Missing ⚠️
...ersioned/typed/apis/v1alpha1/fake/fake_linkrule.go 0.00% 56 Missing ⚠️
pkg/crds/client/clientset/versioned/clientset.go 0.00% 47 Missing ⚠️
...ntset/versioned/typed/apis/v1alpha1/apis_client.go 0.00% 44 Missing ⚠️
...formers/externalversions/apis/v1alpha1/linkrule.go 0.00% 26 Missing ⚠️
...nt/clientset/versioned/fake/clientset_generated.go 0.00% 23 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   17.63%   16.22%   -1.41%     
==========================================
  Files         103      121      +18     
  Lines        9318    10241     +923     
==========================================
+ Hits         1643     1662      +19     
- Misses       7580     8484     +904     
  Partials       95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SOF3
Copy link
Member Author

SOF3 commented Jul 4, 2023

lint broken due to golangci/golangci-lint#3938

@SOF3 SOF3 marked this pull request as ready for review December 5, 2023 09:43
@SOF3 SOF3 enabled auto-merge December 5, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants