Compatibility fixes for WAF and bear#11
Open
martin-schwenke wants to merge 2 commits intokumar8600:masterfrom
Open
Compatibility fixes for WAF and bear#11martin-schwenke wants to merge 2 commits intokumar8600:masterfrom
martin-schwenke wants to merge 2 commits intokumar8600:masterfrom
Conversation
Some build systems (e.g. WAF) build within a separate build directory (e.g. bin/default) and filenames passed to the compiler are relative to that directory. The current code won't match these filenames. Instead, expand the file name in the JSON file relative to the build directory and compare this result to the source filename. Signed-off-by: Martin Schwenke <martin@meltin.net>
compile_commands.json files generated by bear(1) contain an "arguments" element rather than a "command" element. Use the former if the latter doesn't exist. Signed-off-by: Martin Schwenke <martin@meltin.net>
Author
|
Note that one of these commits is a simpler duplicate of #10. I only just noticed this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two compatibility fixes that should be backward compatible. The first helps flycheck-clangcheck work with build systems, such as WAF, that build in a a subdirectory. The second allows the use of compile_commands.json files created using the bear(1) command.