Repository navigation
feat(web): Your Playlists, Your Albums and From Spotify on Home - #1442
Open
saliltimalsina wants to merge 1 commit into
Open
saliltimalsina wants to merge 1 commit into
saliltimalsina wants to merge 1 commit into
Conversation
Home leads with the account's own music after Recently Played, as Spotify's Home does: the library's playlists and saved albums, and once Spotify is connected, the listener's daylist (when Spotify has made one) and their Spotify playlists. Each row links to its page and only shows with something in it. YouTube's own "From your library" shelf is hidden while these show, as its older Recently Played already is.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Home now leads with the listener's own music after Recently Played, as Spotify's Home does:
Each row shows only when there's something in it. YouTube's own "From your library" shelf is hidden while these show, as its older Recently Played already is.
How
ItemShelfinShelfView: a square-lockup shelf whose title links to an app page.37i9dQZF1EP6YuccBxUcC1) and answers it with the signed-in listener's own daylist, renamed through the day.useSpotifyDaylistreads it with the existingspotify.playlistcall, so no extension change is needed. It's left out while empty, which it is for an account with little listening yet.spotifyPlaylistItemis shared withSpotifyPage, which built the same item inline.No new dependencies.
Testing
pnpm typecheck,pnpm testand the app build pass.