Skip to content

refactor(player): remove button backgrounds and update liked icon fill - #1591

Open
Galaxyyss wants to merge 3 commits into
kushagrasinghx:v1.9.1from
Galaxyyss:Remove-Rounded-Background
Open

Galaxyyss wants to merge 3 commits into
kushagrasinghx:v1.9.1from
Galaxyyss:Remove-Rounded-Background

Conversation

@Galaxyyss

@Galaxyyss Galaxyyss commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Refactors the main player screen action buttons by removing their rounded background containers so they float cleanly, updates the liked state of the favorite icon to fill solid white from the inside (using the star icon), and increases the icon sizes by ~25%.

Key Changes

  • Player Actions UI: Removed background circle/container rendering from the like and 3-dots buttons in portrait and landscape players (NowPlayingScreen.kt and LandscapePlayer.kt), using an optional showDisc parameter in PlayerControls.kt while preserving circular hit targets.
  • Icon Sizing: Increased the size of the star and 3-dots icon (CircleGlyph) from 19.dp to 24.dp (~26% increase) exclusively on the main player screen (PlayerControls.kt:782-786), leaving the 34.dp tap targets and other views unchanged.
  • Liked Icon Style: Replaced heart references back to the star icon, rendering the liked state as a solid filled-in white star from the inside.

Testing

  • Verified local build compiles successfully.
  • Tested live on the device: confirmed icons float without rounded backgrounds and correctly fill solid white when liked.

Closes #1585

Automated PR generated 100% via Hermes Agent.

Galaxyyss and others added 3 commits November 7, 2026 15:36
Co-authored-by: Hermes Agent <339329121+hermes-agent-galaxyyss[bot]@users.noreply.github.com>
Co-authored-by: Hermes Agent <339329121+hermes-agent-galaxyyss[bot]@users.noreply.github.com>
…main player screen

Co-authored-by: Hermes Agent <339329121+hermes-agent-galaxyyss[bot]@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant