Skip to content

fix: flush the socket to ensure large messages are fully sent #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvc0 merged 2 commits into from
Aug 17, 2026
Merged

fix: flush the socket to ensure large messages are fully sent #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75fcf4c
fix: flush the socket to ensure large messages are fully sent
anitarua Aug 7, 2026
c5ce88c
fix: error branch and comment
anitarua Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion protosocket-connection/src/connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,12 @@ impl<
}
break if self.send_buffer.is_empty() {
log::debug!("send buffer is empty");
Ok(false)
// Ensure that any remaining data in the TLS buffer is flushed to the socket.
match pin!(&mut self.stream).poll_flush(context) {
Poll::Ready(Ok(())) | Poll::Pending => Ok(false),
Poll::Ready(Err(ref e)) if would_block(e) || interrupted(e) => continue,
Poll::Ready(Err(e)) => Err(e),
}
} else {
// I need to figure out how to get this from the os rather than hardcoding.
// 16 is the lowest I've seen mention of, and I've seen 1024 more commonly.
Expand Down