-
Notifications
You must be signed in to change notification settings - Fork 487
Update CI #1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI #1111
Conversation
Signed-off-by: Xuchun Shang <[email protected]>
Summary of ChangesHello @XucSh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new CI/CD configuration file to automate the labeling of pull requests. By adding a Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a GitHub Actions labeler configuration to automatically apply the run-ci label. However, the current configuration is overly broad, as it applies the label for changes to any file in the repository. This could lead to unnecessary CI runs for non-code changes, such as updates to documentation. My review includes a suggestion to make the file matching patterns more specific to improve efficiency.
| - any-glob-to-any-file: | ||
| - '**/*' No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current glob pattern '**/*' is very broad and will match any file change in the repository, including documentation, .gitignore files, or other non-code assets. This will cause the run-ci label to be applied to every pull request, potentially triggering unnecessary CI workflows and consuming resources. It's better to restrict this to files that actually require CI validation, such as source code and test files. Please adapt the suggested patterns to your project's specific structure.
- any-glob-to-any-file:
- 'src/**/*'
- 'tests/**/*'
# Add other relevant files/directories that should trigger CISigned-off-by: Xuchun Shang <[email protected]>
Signed-off-by: Xuchun Shang <[email protected]>
|
Have tested: XucSh#3 |
Description
Type of Change
How Has This Been Tested?
Checklist