feat: include repeat property in trimmed keyboard events for plugins#1302
Merged
kwaroran merged 1 commit intokwaroran:mainfrom Mar 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Summary
The
trimEventfunction inSafeElement.addEventListenerstrips therepeatproperty fromKeyboardEventobjects before forwarding them to V3 plugins. Withoutrepeat, plugins cannot distinguish an initial key press from auto-repeated keydown events caused by holding a key, forcing plugin authors to implement manual debounce workarounds.Related Issues
None
Changes
repeat: event.repeatto the trimmedKeyboardEventobject inSafeElement.addEventListener(v3.svelte.ts)Impact
if (e.repeat) return;to filter out held-key repeats, eliminating the need for manual debounce logicrepeatis a simple boolean that does not expose keystroke timing informationrepeatare unaffectedAdditional Notes
The existing trimmed properties (
type,key,code,altKey,ctrlKey,shiftKey,metaKey) were chosen to avoid fingerprinting.repeatis consistent with this approach as it carries no timing data.Footnotes
Modifies the behavior of prompting, requesting, or handling responses from AI models. ↩
Over 80% of the code is AI generated. ↩