Fix broadcast channel management to match Apple's APNs API#239
Merged
Conversation
Channel ID is now sent via apns-channel-id header instead of URL path for read/delete operations. Response body is optional since create returns only a channel ID header and delete returns 204 No Content. Channel ID moved from APNSBroadcastChannel body to APNSBroadcastResponse. Test server and tests updated to match. Based on work by @mattglover in #235.
kylebrowning
force-pushed
the
fix/broadcast-channel-management
branch
from
852ad0d to
294203a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apns-channel-idheader instead of URL path for read/delete operations, matching Apple's actual APNs broadcast APIchannelIDmoved fromAPNSBroadcastChannelstruct toAPNSBroadcastResponse(extracted from response headers)Based on work by @mattglover in #235.
Closes #235
Test plan
🤖 Generated with Claude Code