Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applied Set to compare special VLANs collections #510

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Applied Set to compare special VLANs collections #510

merged 3 commits into from
Nov 1, 2024

Conversation

Alopalao
Copy link

@Alopalao Alopalao commented Oct 31, 2024 •
edited
Loading

Closes #506

Summary

Applied a Set to all types of tags and compare available tags with restricted tag collection

Local Tests

Replicated issue case

End-to-End Tests

N/A

@Alopalao Alopalao requested a review from a team as a code owner October 31, 2024 14:16
@Alopalao
Copy link
Author

It can also be changed to set(), just for the comparison.

viniarck
viniarck reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix. Overall, looks good. Asked minor implementation detail changes though.

Also, changelog needs to be updated.

kytos/core/interface.py Outdated Show resolved Hide resolved
@viniarck viniarck self-requested a review November 1, 2024 12:21
viniarck
viniarck approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's ship it @Alopalao, go ahead and merge it.

Finally, let's not forget backporting this too since the issue has the backport labels.

@Alopalao Alopalao changed the title Applied Counter to compare special VLANs collections Applied Set to compare special VLANs collections Nov 1, 2024
@Alopalao Alopalao merged commit 3a21cbe into master Nov 1, 2024
2 checks passed
@Alopalao Alopalao deleted the fix/special_order branch November 1, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniarck viniarck viniarck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False negative on Interface. all_tags_available
2 participants
@Alopalao @viniarck