Fix variable injection, add common labels to all resources, fix requi… #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red options not being passed when etcd is enabled, fix apiservice management always required in clusterrole Signed-off-by: Rafael da Fonseca <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 34 34
Lines 18731 18742 +11
=====================================
- Misses 18731 18742 +11 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rafael da Fonseca <[email protected]>
Signed-off-by: Rafael da Fonseca <[email protected]>
Signed-off-by: Rafael da Fonseca <[email protected]>
vishal-chdhry
approved these changes
Feb 13, 2025
amittiwari28
pushed a commit
to nirmata/reports-server
that referenced
this pull request
Feb 18, 2025
kyverno#256) * Fix variable injection, add common labels to all resources, fix required options not being passed when etcd is enabled, fix apiservice management always required in clusterrole Signed-off-by: Rafael da Fonseca <[email protected]> Fix: allow env variable injection to work for database secrets Fix: Add missing labels to pdb Fix: apiservice management permissions should always be required due to automatic migration code Fix: some required command line options were not being added when using etcd as a database Feat: Add commonLabels input variable, which allows adding arbitrary labels to all resources managed by the chart
amittiwari28
pushed a commit
to nirmata/reports-server
that referenced
this pull request
Feb 18, 2025
kyverno#256) * Fix variable injection, add common labels to all resources, fix required options not being passed when etcd is enabled, fix apiservice management always required in clusterrole Signed-off-by: Rafael da Fonseca <[email protected]> Fix: allow env variable injection to work for database secrets Fix: Add missing labels to pdb Fix: apiservice management permissions should always be required due to automatic migration code Fix: some required command line options were not being added when using etcd as a database Feat: Add commonLabels input variable, which allows adding arbitrary labels to all resources managed by the chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: allow env variable injection to work for database secrets
Fix: Add missing labels to pdb
Fix: apiservice management permissions
should always be required due to automatic migration code
Fix: some required command line options were not being added when using etcd as a database
Feat: Add commonLabels input variable, which allows adding arbitrary labels to all resources managed by the chart