Skip to content

Add excluded potential version for Calculator class #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

E-Rum
Copy link
Contributor

@E-Rum E-Rum commented Apr 30, 2025

Contributor (creator of pull-request) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

Reviewer checklist

  • CHANGELOG updated with public API or any other important changes?

📚 Documentation preview 📚: https://torch-pme--184.org.readthedocs.build/en/184/

@E-Rum E-Rum requested a review from PicoCentauri May 5, 2025 10:33
Copy link
Contributor

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug? Meaning that the exclusion was not working before?

@E-Rum
Copy link
Contributor Author

E-Rum commented May 5, 2025

Yes, it wasn't working before

@PicoCentauri
Copy link
Contributor

wonderful! Can you add a test and update the changelog?

@E-Rum
Copy link
Contributor Author

E-Rum commented May 5, 2025

Yes! Will do as soon as we merge #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants