Skip to content

Fix: don't cache GraphQL types with no name #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bduncanj
Copy link

This addresses issue #1

@jamillosantos jamillosantos self-requested a review July 31, 2019 11:34
@jamillosantos
Copy link
Contributor

Hi @bduncanj, I'm very sorry for the delay (totally missed the notification).

Thank you for your contribution. Before merging it I would like to ask you if it is possible to write some tests? The test here would ensure this error will never happen again.

Write a test that documents your problem (a test that breaks without your fix).

Thanks again.

@bduncanj
Copy link
Author

bduncanj commented Aug 5, 2019

Present issue is that the source tests import the lab259 package (go-graphql-struct) and as such don't end up executing the source code in my branch. The other issues I've addressed are:

  • Getting Input Object working (use object as argument to mutation)
  • Custom GrahpqlTyped (panics because it tries to call Elem() on an interface that isn't a pointer type).

I'll make separate PRs as and when for these other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants