Test with Python 3.12, but don't advertise it, yet #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crossbar is not compatible with Python 3.12, yet: [1] and [2] are not part of a release. A release will probably take some more time [3][4]. Since this is the last remaining issue before we can advertise Python 3.12 support, let's mark these tests as XFAIL for now. [1] crossbario/crossbar#2091 [2] crossbario/crossbar#2093 [3] crossbario/crossbar#2093 (comment) [4] crossbario/crossbar#2091 (comment) Signed-off-by: Bastian Krause <[email protected]>
crossbar is not compatible with Python 3.12, yet: [1] and [2] are not part of a release. A release will probably take some more time [3][4]. We shouldn't advertise Python 3.12 support until that happens. But we can make sure that everything else keeps working fine with Python 3.12 by running the test suite. A previous commit marked the failing crossbar tests as XFAIL for 3.12. [1] crossbario/crossbar#2091 [2] crossbario/crossbar#2093 [3] crossbario/crossbar#2093 (comment) [4] crossbario/crossbar#2091 (comment) Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
force-pushed
the
bst/test-python3.12
branch
from
9eea1cc
to
4f23236
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1306 +/- ##
======================================
Coverage 63.1% 63.1%
======================================
Files 160 160
Lines 11914 11914
======================================
Hits 7520 7520
Misses 4394 4394 ☔ View full report in Codecov by Sentry. |
jluebbe
approved these changes
Dec 15, 2023
Emantor
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
crossbar is not compatible with Python 3.12, yet: [1] and [2] are not part of a release. A release will probably take some more time [3][4].
We shouldn't advertise Python 3.12 support until that happens. But we can make sure that everything else keeps working fine with Python 3.12 by marking the crossbar tests as XFAIL for 3.12 and running the test suite for 3.12.
[1] crossbario/crossbar#2091
[2] crossbario/crossbar#2093
[3] crossbario/crossbar#2093 (comment)
[4] crossbario/crossbar#2091 (comment)
See also #1260 keeping track of Python 3.12 compatibility.
Checklist