Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/Advertise Python 3.13 Support #1511

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

Bastian-Krause
Copy link
Member

@Bastian-Krause Bastian-Krause commented Sep 30, 2024

Description
Add tests for Python 3.13 (expected on 2024-10-07) and advertise support.

Note that the siglent power backend is incompatible with Python 3.13, see #1509. I think this shouldn't stop us from testing/advertising support, right?

Checklist

  • Tests for the feature
  • PR has been tested (CI only)

@Bastian-Krause
Copy link
Member Author

Bastian-Krause commented Oct 8, 2024

Waits for actions/python-versions#312

Edit: merged, PR is ready.

@Bastian-Krause
Copy link
Member Author

Rebased on latest master.

Emantor
Emantor previously approved these changes Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.6%. Comparing base (8d67b3b) to head (bf9bf13).
Report is 5 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1511   +/-   ##
======================================
  Coverage    56.6%   56.6%           
======================================
  Files         168     168           
  Lines       13033   13033           
======================================
  Hits         7385    7385           
  Misses       5648    5648           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The extra test summary shows additional information such as why a test
was skipped. This is helpful to compare test runs on different
Python versions and git states.

Signed-off-by: Bastian Krause <[email protected]>
On Python 3.13, the vxi11 module import fails:

  autodoc: failed to import module 'siglent' from module 'labgrid.driver.power'; the following exception was raised:
  No module named 'xdrlib'

It uses xdrlib which was dropped from Python's standard library with
Python 3.13. See labgrid-project#1507
for more details.

For the time being, mock the vxi11 module to make the doc builds work on
Python 3.13.

Signed-off-by: Bastian Krause <[email protected]>
@Emantor Emantor merged commit 5f0ae27 into labgrid-project:master Oct 21, 2024
11 checks passed
@Bastian-Krause Bastian-Krause deleted the bst/py3.13 branch October 21, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants