Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver/usbstoragedriver: wrap commands #1530

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Emantor
Copy link
Member

@Emantor Emantor commented Oct 21, 2024

Description
Use the wrap_command() function to escape command arguments in case a remote operation over SSH is done.

Checklist

  • PR has been tested

Fixes #1392
Alternative to #1450

@Emantor Emantor force-pushed the topic/wrap-usbstorage branch from 343abb2 to e3e40b5 Compare October 21, 2024 08:23
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.2%. Comparing base (587a872) to head (c04dc1d).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/driver/usbstoragedriver.py 0.0% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1530   +/-   ##
======================================
  Coverage    56.2%   56.2%           
======================================
  Files         170     170           
  Lines       13247   13247           
======================================
  Hits         7449    7449           
  Misses       5798    5798           
Flag Coverage Δ
3.10 56.2% <0.0%> (ø)
3.11 56.2% <0.0%> (ø)
3.12 56.2% <0.0%> (ø)
3.13 56.1% <0.0%> (ø)
3.9 56.2% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Use the wrap_command() function to escape command arguments in case a remote
operation over SSH is done.

Fixes labgrid-project#1392
Alternative to labgrid-project#1450

Signed-off-by: Rouven Czerwinski <[email protected]>
@Emantor Emantor force-pushed the topic/wrap-usbstorage branch from e3e40b5 to c04dc1d Compare January 6, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write_file does not properly escape file names
3 participants