-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add chart #1
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,24 @@ | |||
apiVersion: v2 | |||
name: keeper | |||
description: Helm chart for capacity reservation and overprovisioning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Helm chart for capacity reservation and overprovisioning | |
description: Helm chart for a node capacity reservation and overprovisioning |
@@ -7,9 +7,9 @@ We help companies build, run, deploy and scale software and infrastructure by em | |||
--- | |||
|
|||
## Description | |||
<$chart-name> Helm chart. | |||
keeper Helm chart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to describe how the "tool" can be used and what issues it solves. Basically, the same description from the main README.md would be ok. Or remove the description.
{{- else }} | ||
priorityClassName: {{ include "keeper.fullname" $ }}-op | ||
{{- end }} | ||
containers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to add security context for the Pod with "strict" policy.
app.kubernetes.io/name: {{ include "keeper.name" $ }}-rsrv-{{ $k }} | ||
spec: | ||
automountServiceAccountToken: false | ||
containers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to add security context for the Pod with "strict" policy.
@@ -0,0 +1,11 @@ | |||
apiVersion: rbac.authorization.k8s.io/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are allowing to customize the image, some might need a different RBAC control. I would make this optional, but enabled by default.
# -- Overprovisioning priorityClass name override, will be used instead of priorityClass created in overprovisioning.priorityClass | ||
priorityClassOverride: "" | ||
# -- Map of overprovisioning deployments | ||
map: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
map: | |
map: {} |
# -- Reservation image pull policy | ||
imagePullPolicy: Always | ||
# -- Map of reservation deployments | ||
map: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
map: | |
map: {} |
- -c | ||
args: | ||
- kubectl scale --replicas={{ $v.schedule.up.replicas }} deployment/{{ include "keeper.fullname" $ }}-op-{{ $k }} --namespace {{ $.Release.Namespace }} | ||
resources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to add security context for the Pod with "strict" policy.
- -c | ||
args: | ||
- kubectl scale --replicas={{ $v.schedule.down.replicas }} deployment/{{ include "keeper.fullname" $ }}-rsrv-{{ $k }} --namespace {{ $.Release.Namespace }} | ||
resources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to add security context for the Pod with "strict" policy.
# -- Overprovisioning priorityClass priority | ||
value: "-1000000" | ||
# -- Overprovisioning priorityClass name override, will be used instead of priorityClass created in overprovisioning.priorityClass | ||
priorityClassOverride: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could move this under priorityClass
and rename to name
and use if either for builtin priority class or custom one provided externally.
Description
Add keeper chart
Type of change
fix
)feat
)refactor
)test
)style
)ci
)docs
)How Has This Been Tested?